Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads Confirmations #3406

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Ads Confirmations #3406

merged 2 commits into from
Feb 21, 2019

Conversation

tmancey
Copy link
Contributor

@tmancey tmancey commented Feb 18, 2019

fixes #3117
requires brave/brave-core#1645
requires brave-intl/bat-native-confirmations#67

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@tmancey tmancey self-assigned this Feb 18, 2019
@tmancey tmancey requested a review from bridiver February 18, 2019 17:37
@tmancey tmancey mentioned this pull request Feb 18, 2019
18 tasks
@tmancey tmancey force-pushed the fix-linking-error-rebase branch from 21937c3 to 83b54fc Compare February 18, 2019 17:49
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@tmancey tmancey force-pushed the fix-linking-error-rebase branch from 91b7d45 to f291623 Compare February 21, 2019 11:54
@tmancey tmancey requested a review from NejcZdovc February 21, 2019 18:24
@NejcZdovc NejcZdovc added this to the 0.63.x - Nightly milestone Feb 21, 2019
@NejcZdovc NejcZdovc changed the title Fix linking error rebase Ads Confirmations Feb 21, 2019
@ryanml ryanml assigned ryanml and unassigned ryanml Feb 21, 2019
@tmancey tmancey merged commit b9bcd27 into master Feb 21, 2019
@tmancey tmancey deleted the fix-linking-error-rebase branch February 21, 2019 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirmations implementation
4 participants