Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm if Ad can be shown #2907

Closed
1 of 2 tasks
tmancey opened this issue Jan 10, 2019 · 2 comments · Fixed by brave/brave-core#1645
Closed
1 of 2 tasks

Confirm if Ad can be shown #2907

tmancey opened this issue Jan 10, 2019 · 2 comments · Fixed by brave/brave-core#1645
Labels
feature/ads feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No release-notes/exclude
Milestone
0.63.x - Release ...

Comments

@tmancey
Copy link
Contributor

tmancey commented Jan 10, 2019 •
edited
Loading

Subtasks:

  • Implement Ads service implementation IsConfirmationsReadyToShowAds as a proxy to bat-native-ledger IsConfirmationsReadyToShowAds
  • Implement bat-native-ledger IsConfirmationsReadyToShowAds as a proxy to bat-native-confirmations IsConfirmationsReadyToShowAds (see bool AdsServiceImpl::IsConfirmationsReadyToShowAds())
@tmancey tmancey added this to the 1.x Backlog milestone Jan 10, 2019
@tmancey tmancey added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Jan 11, 2019
@tmancey tmancey self-assigned this Jan 13, 2019
@tmancey tmancey removed their assignment Jan 15, 2019
@tmancey tmancey modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Jan 15, 2019
@tmancey
Copy link
Contributor Author

tmancey commented Jan 15, 2019 •
edited
Loading

Fixed by brave/brave-core#1645

@tmancey tmancey closed this as completed Jan 15, 2019
@tmancey tmancey modified the milestones: Dupe / Invalid / Not actionable, 0.63.x - Nightly Feb 21, 2019
@tmancey tmancey mentioned this issue Feb 21, 2019
Merged
18 tasks
@LaurenWags
Copy link
Member

Discussed with Terry/Jimmy - marking as QA/No as testing will be completed with #3117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/ads feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No release-notes/exclude
Projects
None yet
Milestone
0.63.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Ads Confirmations brave/brave-core
3 participants
@tmancey @rebron @LaurenWags