Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-close the network selector screen when a network is selected #22424

Closed
srirambv opened this issue Apr 20, 2022 · 1 comment · Fixed by brave/brave-core#13148
Closed

Auto-close the network selector screen when a network is selected #22424

srirambv opened this issue Apr 20, 2022 · 1 comment · Fixed by brave/brave-core#13148
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

As part of #20471, we show a full screen network selection page. But selecting a network doesn't auto-close the screen and go back to portfolio causing user to do an extra swipe/tap to go back. This should be avoided as the user made a selection already

Steps to reproduce

  1. Create a wallet on Beta
  2. Select network dropdown
  3. Select a different network, screen is not auto closed

Actual result

Network.Auto.close.mp4

Expected result

Auto-close the network selector screen when a network is selected

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet):All
  • Android version: All

Brave version

1.38.103

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

@srirambv srirambv added bug QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Apr 20, 2022
@srirambv srirambv added this to Web3 Apr 20, 2022
@qamarngr qamarngr self-assigned this Apr 22, 2022
@qamarngr qamarngr moved this to In Progress in Web3 Apr 22, 2022
Repository owner moved this from In Progress to Done in Web3 Apr 25, 2022
@qamarngr qamarngr added this to the 1.40.x - Nightly milestone May 4, 2022
@srirambv
Copy link
Contributor Author

srirambv commented Jun 6, 2022

Verification passed on Oppo Reno 5 with Android 12 running 1.40.86 x64 build

  • Verified steps from issue description
  • Verified selecting a network automatically closes the drop-down selector
22424-ARM.mp4

Verification passed on Samsung Tab A with Android 10 running 1.40.86 x64 build

  • Verified steps from issue description
  • Verified selecting a network automatically closes the drop-down selector
22424-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants