Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto close netowrk selector and item ripple effect #13148

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

qamarngr
Copy link
Contributor

@qamarngr qamarngr commented Apr 22, 2022

finish activity on selection of a Network.
Also applied foreground ripple effect on network list item

22424.mp4

Resolves brave/brave-browser#22424

brave/brave-browser#22424

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@qamarngr qamarngr self-assigned this Apr 22, 2022
@qamarngr qamarngr added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 22, 2022
@qamarngr qamarngr changed the title Auto close netowrk selector and item foreground Auto close netowrk selector and item ripple effect Apr 22, 2022
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Pavneet-Sing
Copy link

Please add a gif or video for the UI changes.

@qamarngr qamarngr merged commit f6b6145 into brave:master Apr 25, 2022
@qamarngr qamarngr deleted the auto-close-network-selector branch April 25, 2022 12:50
@qamarngr qamarngr added this to the 1.40.x - Nightly milestone May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-close the network selector screen when a network is selected
4 participants