Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move wallet currency code list into Brave Wallet component #22481

Open
StephenHeaps opened this issue Apr 21, 2022 · 0 comments
Open

Move wallet currency code list into Brave Wallet component #22481

StephenHeaps opened this issue Apr 21, 2022 · 0 comments
Labels
dev-experience feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop

Comments

@StephenHeaps
Copy link

StephenHeaps commented Apr 21, 2022 •
edited
Loading

Description

Currently the list of currency codes is kept in the js for the wallet settings. I think it'd be useful if all platforms shared the same list of currency codes if they lived in the brave_wallet component (I think Wallet Service is a good spot as it has the other currency methods).

This would be used in brave/brave-ios#5276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-experience feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop
Projects
Web3
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kylehickinson @StephenHeaps