Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more UD domains #22102

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Add more UD domains #22102

merged 2 commits into from
Feb 16, 2024

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Feb 15, 2024

Resolves brave/brave-browser#36131
Resolves brave/brave-browser#29371
Resolves brave/brave-browser#30290

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Set IPFS setting to gateway and visit these test domains.
reseller-test-udtesting-319708317921.altimist
reseller-test-udtesting-266798386399.anime
reseller-test-udtesting-257453775377.klever
reseller-test-udtesting-444498982797.manga
reseller-test-udtesting-260502680311.polygon
reseller-test-udtesting-451650328921.unstoppable

@yrliou yrliou requested review from a team and iefremov as code owners February 15, 2024 19:53
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Feb 15, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@yrliou yrliou requested a review from a team as a code owner February 15, 2024 21:49
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ Wallet Front-end

Comment on lines +103 to +107
public static let supportedUDExtensions = [
".crypto", ".x", ".nft", ".dao", ".wallet",
".blockchain", ".bitcoin", ".zil", ".altimist", ".anime",
".klever", ".manga", ".polygon", ".unstoppable", ".pudgy"
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say we need that list sorted and in one place.
We should have a mojo method to backend ResolveWalletAddress(string address, BlockhainToken token) which is triggered when address field has a dot.
Not now of course :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ for both

A few spots we need to expose constants better for all platforms, like currency codes with #22481 :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@kdenhartog kdenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for security

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but if we are going to keep adding/modifying these, perhaps we should consider changing the UI so that these are split out into a separate string that doesn't need to be translated.

@yrliou
Copy link
Member Author

yrliou commented Feb 16, 2024

@mkarolin Totally agreed with you, this one has some urgency since we need to uplift to 1.63.x, I'll create a follow-up issue to fix this on master.

@yrliou yrliou merged commit 2898bdb into master Feb 16, 2024
19 checks passed
@yrliou yrliou deleted the update_ud_domains branch February 16, 2024 16:55
@github-actions github-actions bot added this to the 1.65.x - Nightly milestone Feb 16, 2024
brave-builds added a commit that referenced this pull request Feb 16, 2024
brave-builds added a commit that referenced this pull request Feb 16, 2024
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.65.8 Chromium: 122.0.6261.43 (Official Build) nightly (64-bit)
-- | --
Revision | 99fa7076dd9d262e50bfea1be951e68b0ce236d0
OS | Windows 11 Version 23H2 (Build 22631.3155)

Using the STR/Cases outlined via #22102 (comment) and ensured that the UD domains resolved without any issues after Gateway was enabled via Method to resolve IPFS resources under brave://settings/web3 as per the following:

Example Example Example Example Example Example Example
UD1 UD2 UD3 UD4 UD5 UD6 UD7

kjozwiak pushed a commit that referenced this pull request Feb 17, 2024
kjozwiak pushed a commit that referenced this pull request Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new UD domains Add new UD TLDs to supportedUDExtensions Remove .888 TLD from supported UD Extensions