-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more UD domains #22102
Add more UD domains #22102
Conversation
A Storybook has been deployed to preview UI for the latest push |
b80974c
to
fc62bc3
Compare
fc62bc3
to
01731a9
Compare
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ Wallet Front-end
public static let supportedUDExtensions = [ | ||
".crypto", ".x", ".nft", ".dao", ".wallet", | ||
".blockchain", ".bitcoin", ".zil", ".altimist", ".anime", | ||
".klever", ".manga", ".polygon", ".unstoppable", ".pudgy" | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say we need that list sorted and in one place.
We should have a mojo method to backend ResolveWalletAddress(string address, BlockhainToken token)
which is triggered when address field has a dot.
Not now of course :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ for both
A few spots we need to expose constants better for all platforms, like currency codes with #22481 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for security
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but if we are going to keep adding/modifying these, perhaps we should consider changing the UI so that these are split out into a separate string that doesn't need to be translated.
@mkarolin Totally agreed with you, this one has some urgency since we need to uplift to 1.63.x, I'll create a follow-up issue to fix this on master. |
Verification PASSED on
Using the STR/Cases outlined via #22102 (comment) and ensured that the
|
Uplift of #22102 (squashed) to beta
Uplift of #22102 (squashed) to release
Resolves brave/brave-browser#36131
Resolves brave/brave-browser#29371
Resolves brave/brave-browser#30290
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Set IPFS setting to gateway and visit these test domains.
reseller-test-udtesting-319708317921.altimist
reseller-test-udtesting-266798386399.anime
reseller-test-udtesting-257453775377.klever
reseller-test-udtesting-444498982797.manga
reseller-test-udtesting-260502680311.polygon
reseller-test-udtesting-451650328921.unstoppable