Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new UD TLDs to supportedUDExtensions #30290

Closed
V-Shadbolt opened this issue May 11, 2023 · 0 comments · Fixed by brave/brave-core#22102
Closed

Add new UD TLDs to supportedUDExtensions #30290

V-Shadbolt opened this issue May 11, 2023 · 0 comments · Fixed by brave/brave-core#22102
Labels
feature/web3/ddns feature/web3/unstoppable-domains Label for unstoppable domains feature feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude

Comments

@V-Shadbolt
Copy link

Description

Current supportedUDExtensions array does not include newly released UD TLDs causing failed IPFS resolutions. Suggest adding support for .zil, .klever, .hi, .kresus, .polygon, .binanceus etc.

export const supportedUDExtensions = [
  '.crypto', '.x', '.nft', '.dao', '.wallet', '.888', '.blockchain', '.bitcoin']

https://github.com/brave/brave-core/blob/master/components/brave_wallet_ui/common/constants/domain-extensions.ts#L9

Steps to Reproduce

  1. Open a new Tab
  2. Search for jim-unstoppable.polygon/
  3. Observe the "This site can't be reached" error page.

Actual result:

"This site can't be reached" error page

Expected result:

IPFS site should resolve and display in Brave for all Unstoppable TLDs

Reproduces how often:

100% as TLD support is based on regex and constants.

Desktop Brave version:

1.51.114 Chromium: 113.0.5672.92 (Official Build) (arm64)

Version/Channel Information:

  • Can you reproduce this issue with the current release? tbd
  • Can you reproduce this issue with the beta channel? tbd
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/ddns feature/web3/unstoppable-domains Label for unstoppable domains feature feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants