Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for new UD TLDs #18461

Closed
wants to merge 2 commits into from

Conversation

V-Shadbolt
Copy link

Resolves brave/brave-browser#30290

Resolves brave/brave-browser#29371

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Brave should resolve all UD addresses
Wiki should mention additional TLDs

@V-Shadbolt V-Shadbolt requested review from a team and iefremov as code owners May 11, 2023 21:41
@supermassive supermassive self-requested a review May 12, 2023 01:37
@supermassive
Copy link
Collaborator

@kdenhartog @bbondy need your input here

@bbondy
Copy link
Member

bbondy commented May 24, 2023

@supermassive sorry for the delay here I thought I had responded already. Yes you can review and accept this as long as the changes, tests, and CI look good.

Copy link
Member

@kdenhartog kdenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.hi and all two letter TLDS are reserved for country code TLDs by ICANN so we wouldn't be able to support this one.

I've checked the rest for conflicts and have not spotted any other issues.

.hi and all two letter TLDS are reserved for country code TLDs by ICANN
@V-Shadbolt
Copy link
Author

@kdenhartog I've gone through and removed .hi from the PR per the recommendation! Do let me know if we need to make other changes.

@supermassive
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new UD TLDs to supportedUDExtensions Remove .888 TLD from supported UD Extensions
4 participants