Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share UD Domains list across platforms #36165

Open
StephenHeaps opened this issue Feb 16, 2024 · 0 comments
Open

Share UD Domains list across platforms #36165

StephenHeaps opened this issue Feb 16, 2024 · 0 comments
Labels
dev-concern feature/web3/ddns OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality

Comments

@StephenHeaps
Copy link

Description

Currently we have separate lists of supported UD domains on each platform, we should expose this list in core to share between platforms.

iOS frontend: https://github.com/brave/brave-core/blob/35d4ae08b4676342df9ac2e3bfd43f10bdf04f68/ios/brave-ios/Sources/BraveWallet/WalletConstants.swift#L103-L107

Desktop frontend: https://github.com/brave/brave-core/blob/35d4ae08b4676342df9ac2e3bfd43f10bdf04f68/components/brave_wallet_ui/common/constants/domain-extensions.ts#L9-L25

It may be beneficial to have a list of eth/sol supported DDNS domains; though currently only .eth / .sol supported respectively.

@StephenHeaps StephenHeaps added OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality feature/web3/ddns labels Feb 16, 2024
@Douglashdaniel Douglashdaniel moved this to Backlog in Web3 Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-concern feature/web3/ddns OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality
Projects
Status: Backlog
Development

No branches or pull requests

2 participants