Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new UD domains #36131

Closed
jamesmudgett opened this issue Feb 15, 2024 · 4 comments · Fixed by brave/brave-core#22102
Closed

Add new UD domains #36131

jamesmudgett opened this issue Feb 15, 2024 · 4 comments · Fixed by brave/brave-core#22102
Assignees
@yrliou
Labels
feature/web3/unstoppable-domains Label for unstoppable domains feature feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - iPhone X QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.63.x - Release

Comments

@jamesmudgett
Copy link

jamesmudgett commented Feb 15, 2024 •
edited
Loading

Review: https://github.com/brave/reviews/issues/1516

Add the following domains, targetting 1.63.x, an uplift will be required:

.altimist
.anime
.klever
.manga
.polygon
.unstoppable

Test domains

reseller-test-udtesting-319708317921.altimist
reseller-test-udtesting-266798386399.anime
reseller-test-udtesting-257453775377.klever
reseller-test-udtesting-444498982797.manga
reseller-test-udtesting-260502680311.polygon
reseller-test-udtesting-451650328921.unstoppable
@jamesmudgett jamesmudgett converted this from a draft issue Feb 15, 2024
@jamesmudgett jamesmudgett added priority/P2 A bad problem. We might uplift this to the next planned release. feature/web3/unstoppable-domains Label for unstoppable domains feature labels Feb 15, 2024
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Feb 15, 2024
@yrliou yrliou self-assigned this Feb 15, 2024
@yrliou yrliou mentioned this issue Feb 15, 2024
Merged
24 tasks
@yrliou yrliou added QA/Yes and removed QA/No labels Feb 15, 2024
@yrliou yrliou moved this from Backlog to In Review in Web3 Feb 15, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Feb 16, 2024
@brave-builds brave-builds added the feature/web3/wallet Integrating Ethereum+ wallet support label Feb 16, 2024
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Feb 16, 2024
This was referenced Feb 16, 2024
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.63.157 or higher for 1.63.x verification 👍

@yrliou yrliou added OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality labels Feb 19, 2024
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.63.157 Chromium: 122.0.6261.43 (Official Build) (64-bit)
Revision 5fbb7c60cc44e15a910a39a349e632f1b904c58e
OS Windows 11 Version 23H2 (Build 22631.3155)
  • Verified steps from brave/brave-core#22102
  • Verified .altimist, .anime, .klever, .manga, .polygon & .unstoppable domains resolve when IPFS resolve setting is set Gateway
36131.mp4

@srirambv
Copy link
Contributor

Verification passed on Google Pixel 8 with Android 14 running 1.63.157 x64 build

  • Verified .altimist, .anime, .klever, .manga, .polygon & .unstoppable domains resolve on mobile when Resolve UD Domain is set to Enabled
36131.mp4

@kjozwiak kjozwiak mentioned this issue Mar 4, 2024
Closed
26 tasks
@srirambv
Copy link
Contributor

Verification passed on iPhone 13 with iOS 17.4 running 1.63 (173)

  • Verified steps from brave/brave-core#22102
  • Verified .altimist, .anime, .klever, .manga, .polygon & .unstoppable domains resolve when IPFS resolve setting is set Gateway
image image image
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
feature/web3/unstoppable-domains Label for unstoppable domains feature feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - iPhone X QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.63.x - Release
Development

Successfully merging a pull request may close this issue.

Add more UD domains brave/brave-core
5 participants
@jamesmudgett @kjozwiak @yrliou @srirambv @brave-builds