Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign Filecoin transactions with hardware wallets #22599

Closed
spylogsster opened this issue Apr 28, 2022 · 2 comments · Fixed by brave/brave-core#13227
Closed

Sign Filecoin transactions with hardware wallets #22599

spylogsster opened this issue Apr 28, 2022 · 2 comments · Fixed by brave/brave-core#13227
Assignees
@spylogsster
Labels
feature/web3/wallet/filecoin feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.40.x - Release

Comments

@spylogsster
Copy link

Placeholder for signing Filecoin transactions with hardware wallets
@spylogsster spylogsster self-assigned this Apr 28, 2022
@spylogsster spylogsster added this to Web3 Apr 28, 2022
@spylogsster spylogsster moved this to In Progress in Web3 Apr 28, 2022
@spylogsster spylogsster mentioned this issue May 14, 2022
Merged
25 tasks
Repository owner moved this from In Progress to Done in Web3 May 20, 2022
@brave-builds brave-builds mentioned this issue May 20, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.40.75 or higher for 1.40.x verification 👍

@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label May 26, 2022
@srirambv
Copy link
Contributor

srirambv commented Jun 2, 2022

Brave 1.40.80 Chromium: 102.0.5005.78 (Official Build) beta (64-bit)
Revision df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS ☑️ Linux ☑️ Windows 11 Version 22H2
(Build 22621.1) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#13227
  • Verified able to sign and publish Filecoin transactions using hardware wallets
  • Verified transaction history is added to the submitted transaction
  • Verified transaction status changed to Confirmed from Submitted
  • Encountered #23048 & #23200 & #23201
22599-Linux.mp4
22599-Windows.mov
22599-macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
feature/web3/wallet/filecoin feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.40.x - Release
Development

Successfully merging a pull request may close this issue.

Sign and publish Filecoin using hardware wallets brave/brave-core
4 participants
@kjozwiak @spylogsster @srirambv @LaurenWags