Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewire correct block explorer for Filecoin Transactions #23048

Closed
srirambv opened this issue May 25, 2022 · 2 comments · Fixed by brave/brave-core#13598
Closed

Rewire correct block explorer for Filecoin Transactions #23048

srirambv opened this issue May 25, 2022 · 2 comments · Fixed by brave/brave-core#13598
Assignees
@cypt4
Labels
feature/web3/wallet/filecoin feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/exclude
Milestone
1.40.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Rewire correct block explorer for Filecoin Transactions

Steps to Reproduce

  1. Initiate a transaction on Filecoin
  2. Click on View on block explorer
  3. Opens a new tab and loads https://calibration.node.glif.io/rpc/v0/tx/<TX_ID> which shows {"message":"Missing Authentication Token"} message

Actual result:

Filecoin.Block.Explorer.mov

Expected result:

Load correct block explorer to view transactions

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.41.11 Chromium: 102.0.5005.61 (Official Build) nightly (64-bit)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS Windows 11 Version 22H2 (Build 22621.1)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? nA

Miscellaneous Information:

cc: @jamesmudgett @spylogsster @muliswilliam @Douglashdaniel
@srirambv srirambv added this to Web3 May 25, 2022
@srirambv srirambv mentioned this issue May 25, 2022
Merged
25 tasks
@bbondy bbondy added this to the 1.40.x - Beta milestone Jun 1, 2022
@srirambv srirambv mentioned this issue Jun 2, 2022
Closed
@cypt4 cypt4 mentioned this issue Jun 3, 2022
Merged
25 tasks
cypt4 added a commit to brave/brave-core that referenced this issue Jun 3, 2022
@cypt4
Change filecoin explorer urls
f133d5a 
Resolves brave/brave-browser#23048

Use another explorer url for filecoin network to open transaction explorer tab.
Previous urls did not have web interface.
@cypt4 cypt4 moved this to Done in Web3 Jun 3, 2022
@brave-builds brave-builds mentioned this issue Jun 3, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Jun 7, 2022

The above will require 1.40.89 or higher for 1.40.x verification 👍

@srirambv
Copy link
Contributor Author

Brave 1.40.95 Chromium: 102.0.5005.115 (Official Build) beta (64-bit)
Revision 174dbe6e33bc81994fceb71d751be201d0b4803d-refs/branch-heads/5005_109@{#3}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.708) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from issue description
  • Verified correct block explorer is loaded for both Mainnet and Testnet
23048-Linux.mp4
23048-Windows.mp4
23048-macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
feature/web3/wallet/filecoin feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.40.x - Release
Development

Successfully merging a pull request may close this issue.

Change filecoin explorer urls brave/brave-core
4 participants
@bbondy @kjozwiak @srirambv @cypt4