Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hostname field in submitted user-support data to Guardian lists city, rather than actual hostname #22628

Closed
stephendonner opened this issue Apr 29, 2022 · 2 comments · Fixed by brave/brave-core#13382

Comments

@stephendonner
Copy link

stephendonner commented Apr 29, 2022

Description

Hostname field in submitted user-support data to Guardian lists city, rather than actual hostname

Steps to Reproduce

  1. install 1.39.86
  2. launch Brave using --vmodule="*/skus/*"=1 --enable-logging=stderr
  3. via brave://flags, set Enable experimental SKU SDK to Enabled
  4. also set Experimental SKU Environment to Development
  5. click to Relaunch
  6. load account.brave.software
  7. enter basic auth creds for site
  8. enter an email and click Get login link
  9. check your email inbox
  10. click Log in to Brave or the link in the email
  11. click on Browse plans
  12. scroll down and click on Buy now for Brave VPN Subscription
  13. enter payment details on https://checkout.stripe.com/pay/cs_test…
  14. click Subscribe
  15. you should get a Complete your purchase... screen
  16. click on Complete payment
  17. click on the VPN icon
  18. click on the Settings gear icon
  19. click on Contact technical support
  20. See that VPN hostname is checked
  21. Submit the issue with details by clicking on Submit
  22. Check with Guardian (once fixed) to ensure their Hostname: field (VPN hostname: in our UI) has the correct VPN-location endpoint populated

Actual result:

Currently, that's populated with the city, rather than the hostname, which in my case below was: sanjose-ipsec-1.guardianapp.com

Submitted data Received data from Guardian BraveVPN in Windows
15804-windows-7 (1) Screen Shot 2022-04-29 at 10 29 13 AM Screenshot 2022-04-29 103015

Expected result:

Reproduces how often:

100%

Brave version (brave://version info)

1.39.86 on Windows 10

cc @bsclifton @rebron

@bsclifton
Copy link
Member

For example it's submitting San Jose, CA instead of sanjose-ipsec-1.guardianapp.com

@stephendonner
Copy link
Author

stephendonner commented May 25, 2022

Verified PASSED using

Brave 1.41.14 Chromium: 102.0.5005.61 (Official Build) nightly (x86_64)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS macOS Version 11.6.6 (Build 20G624)

Followed my original steps to reproduce (inline, above).

Confirmed submitting a technical-support request correctly includes the hostname (sanjose-ipsec-1.guardianapp.com), rather than city name (San Jose, CA), as before.

client UI from Guardian macOS Network panel
Screen Shot 2022-05-25 at 10 08 08 AM Bildschirmfoto 2022-05-25 um 19 12 07 Screen Shot 2022-05-25 at 10 17 06 AM

Verification PASSED on

Brave | 1.41.91 Chromium: 103.0.5060.114 (Official Build) beta (64-bit)
-- | --
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | Windows 10 Version 21H2 (Build 19044.1766)

Confirmed submitting a technical-support request correctly includes the hostname (singapore-10.sgw.guardianapp.com), rather than city name (Singapore), as before.

client UI windows Network panel
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment