-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow values to be set lower than current base fee #22648
Comments
Maybe surface a warning if the fee is below the recommended value. |
Any movement on this? Would love to actually be able to use the Brave wallet. |
This issue makes the brave wallet useless for experienced users |
Thanks for the ping, we'll get it prioritized. |
@bbondy I tried out the wallet again today, it seems like you've gone in the opposite direction and completely stripped any control the user might have. The wallet refused to even send my test transaction. Is there any hope the brave wallet will be something a non-beginner will ever use? Or is this not your design goal and I should just stick with metamask. |
Surely I don't think you think that I prioritized a direction of not allowing transactions? That would be odd indeed! |
The wallet refuses to send a 0 ETH transaction, or send it the wallet to ones own address (both transactions that have legitimate use cases, for example, in canceling a previous pending tx). Seems like the purpose is to help beginners, but these sort of rails make the wallet a non-starter for advanced users. |
Any update on this? I want to lower my gas fees |
I like the wallet, it is working faster than MM for me, quite more indeed. Looks smooth and pretty, and the native implementation in the browser is a big deal. I would want to know if there is any plan to implement the lower gas fee for custom transactions, a very needed feature for an everyday use in my opinion. |
@santoniusjearings, @raben1 , this feature is currently in-progress as of yesterday. Continue to follow this issue if you're interested in receiving further updates. |
Verification passed on
22648.mp4Verification passed on
22648.mp4Verification passed on
22648.mov |
Currently the user can't set lower gas fees, just higher (they can get rid of the miner tip only)
We show the "Current base fee" to what our over estimation is (currently 33%).
I think we should probably show that as the actual current base fee, and not the inflated one.
I.e. for display only.
Now I know the excess is returned to the user, but users are still confused about it.
See here:
https://community.brave.com/t/cant-set-manual-gas-avalanche-chain/375388
Users are also confused why the save button ever goes to a disabled state.
This is because we allow them to set the max fee, and they can set it to an inconsistent value.
i.e. we force a value for the base fee that we decide.
Should we allow a lower forced base fee to be set? I.e. the transaction wouldn't be eligible to go in a block until the base fee reached that range. Maybe the user for example is ok if the transaction takes a day to be processed.
Thoughts?
cc @jamesmudgett @onyb
The text was updated successfully, but these errors were encountered: