Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow values to be set lower than current base fee #22648

Closed
bbondy opened this issue May 2, 2022 · 11 comments · Fixed by brave/brave-core#16810
Closed

Allow values to be set lower than current base fee #22648

bbondy opened this issue May 2, 2022 · 11 comments · Fixed by brave/brave-core#16810
Assignees
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes needs-text-change This change requires some careful wording. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@bbondy
Copy link
Member

bbondy commented May 2, 2022

Screen Shot 2022-05-02 at 11 26 52 AM

Currently the user can't set lower gas fees, just higher (they can get rid of the miner tip only)

We show the "Current base fee" to what our over estimation is (currently 33%).
I think we should probably show that as the actual current base fee, and not the inflated one.
I.e. for display only.

Now I know the excess is returned to the user, but users are still confused about it.
See here:
https://community.brave.com/t/cant-set-manual-gas-avalanche-chain/375388

Users are also confused why the save button ever goes to a disabled state.
This is because we allow them to set the max fee, and they can set it to an inconsistent value.
i.e. we force a value for the base fee that we decide.

Should we allow a lower forced base fee to be set? I.e. the transaction wouldn't be eligible to go in a block until the base fee reached that range. Maybe the user for example is ok if the transaction takes a day to be processed.

Thoughts?
cc @jamesmudgett @onyb

@bbondy bbondy added this to Web3 May 2, 2022
@jamesmudgett
Copy link

Maybe surface a warning if the fee is below the recommended value.

@jamesmudgett jamesmudgett added feature/web3/wallet Integrating Ethereum+ wallet support priority/P2 A bad problem. We might uplift this to the next planned release. front-end-change This task is a front end task and doesn't need any C++ changes feature/web3/wallet/core labels Jun 7, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jun 7, 2022
@scmart
Copy link

scmart commented Jul 21, 2022

@bbondy @jamesmudgett

Any movement on this? Would love to actually be able to use the Brave wallet.

@krisbitney
Copy link

This issue makes the brave wallet useless for experienced users

@bbondy
Copy link
Member Author

bbondy commented Sep 1, 2022

This issue makes the brave wallet useless for experienced users

Thanks for the ping, we'll get it prioritized.

@scmart
Copy link

scmart commented Oct 27, 2022

@bbondy I tried out the wallet again today, it seems like you've gone in the opposite direction and completely stripped any control the user might have. The wallet refused to even send my test transaction. Is there any hope the brave wallet will be something a non-beginner will ever use? Or is this not your design goal and I should just stick with metamask.

@bbondy
Copy link
Member Author

bbondy commented Oct 27, 2022

it seems like you've gone in the opposite direction and completely stripped any control the user might have. The wallet refused to even send my test transaction.

Surely I don't think you think that I prioritized a direction of not allowing transactions? That would be odd indeed!
It does seem like you're running into a bug but I wonder if you could share more detail that might help us troubleshoot the new issue. Also instead of hijacking this issue it might be better to post a new issue.

@scmart
Copy link

scmart commented Oct 27, 2022

The wallet refuses to send a 0 ETH transaction, or send it the wallet to ones own address (both transactions that have legitimate use cases, for example, in canceling a previous pending tx). Seems like the purpose is to help beginners, but these sort of rails make the wallet a non-starter for advanced users.

@santoniusjearings
Copy link

Any update on this? I want to lower my gas fees

@josheleonard josheleonard self-assigned this Jan 19, 2023
@josheleonard josheleonard moved this from Backlog to In Progress in Web3 Jan 19, 2023
@josheleonard josheleonard added needs-text-change This change requires some careful wording. design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Jan 19, 2023
@raben1
Copy link

raben1 commented Jan 20, 2023

I like the wallet, it is working faster than MM for me, quite more indeed. Looks smooth and pretty, and the native implementation in the browser is a big deal. I would want to know if there is any plan to implement the lower gas fee for custom transactions, a very needed feature for an everyday use in my opinion.
I know this is not the thread but I must agree with @scmart about the 0 value and self-transactions, maybe less used but necessary in some cases. Maybe these functions could be added as an option in the wallet settings, like "Advanced functions" or so, and in the same way protect new users and allow a more custom wallet use.

@josheleonard
Copy link

@santoniusjearings, @raben1 , this feature is currently in-progress as of yesterday. Continue to follow this issue if you're interested in receiving further updates.

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Linux
  • Verified steps from brave/brave-core#16810
  • Verified able to set value lower than the current base fee for a send transaction
22648.mp4

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16810
  • Verified able to set value lower than the current base fee for a send transaction
22648.mp4

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (arm64)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16810
  • Verified able to set value lower than the current base fee for a send transaction
22648.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes needs-text-change This change requires some careful wording. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

9 participants