Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allow gas price value below current base fee #16810

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

josheleonard
Copy link
Contributor

@josheleonard josheleonard commented Jan 23, 2023

Resolves brave/brave-browser#22648
Resolves brave/brave-browser#21147

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Screen.Recording.2023-01-27.at.5.03.43.PM.mov

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 23, 2023
@josheleonard josheleonard force-pushed the fix-allow-gas-price-value-below-current-base-fee branch 6 times, most recently from 815ced3 to 03fb6a6 Compare January 27, 2023 16:51
@josheleonard josheleonard force-pushed the fix-allow-gas-price-value-below-current-base-fee branch 5 times, most recently from c4b8b3f to 4404923 Compare January 27, 2023 21:37
@josheleonard josheleonard force-pushed the fix-allow-gas-price-value-below-current-base-fee branch from 4404923 to 0c7385b Compare January 27, 2023 22:05
@josheleonard josheleonard marked this pull request as ready for review January 27, 2023 22:05
@josheleonard josheleonard requested review from a team as code owners January 27, 2023 22:05
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ for components/brave_wallet/browser/brave_wallet_constants.h change

Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@josheleonard josheleonard merged commit 1666b2a into master Jan 30, 2023
@josheleonard josheleonard deleted the fix-allow-gas-price-value-below-current-base-fee branch January 30, 2023 20:29
@github-actions github-actions bot added this to the 1.49.x - Nightly milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow values to be set lower than current base fee Unable to set custom gas outside strict limits
3 participants