Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN context-menu items should use sentence casing #22653

Closed
stephendonner opened this issue May 2, 2022 · 6 comments
Closed

VPN context-menu items should use sentence casing #22653

stephendonner opened this issue May 2, 2022 · 6 comments

Comments

@stephendonner
Copy link

Description

VPN context-menu items should use sentence casing

Steps to Reproduce

  1. install 1.39.87
  2. launch Brave
  3. set up VPN
  4. context-click on the VPN icon
  5. look at the text capitalization

Actual result:

Screen Shot 2022-05-02 at 10 12 07 AM

Expected result:

Screen Shot 2022-05-02 at 10 17 41 AM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.39.87 Chromium: 101.0.4951.41 (Official Build) beta (x86_64)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS macOS Version 11.6.5 (Build 20G527)

cc @rmcfadden3 @bsclifton @Tonev

@Tonev
Copy link
Contributor

Tonev commented May 6, 2022

Hey, @stephendonner 👋

This one might be intentional as there is a check for casing inside the strings file. I'm not sure how to proceed in this case, whether deleting the entries inside the titlecase check would be enough to resolve your ticket.

image

@stephendonner
Copy link
Author

It's all good; @nullhook will know 👍 Thanks for looking!

@rmcfadden3
Copy link

@stephendonner — yeah, good catch. Should be sentence case. So:

  • Hide VPN button in toolbar
  • Send feedback
  • About Brave VPN
  • Manage my plan

@spylogsster
Copy link

Looks like this is fixed already:
image

@MadhaviSeelam
Copy link

MadhaviSeelam commented Oct 28, 2022

Verification PASSED using

Brave | 1.46.83 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
-- | --
Revision | a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS | Windows 11 Version 21H2 (Build 22000.1098)

Verified using original STR from #22653 (comment)

Confirmed correct sentence casing for VPN context-menu, matched with hamburger menu-->Brave VPN
(and as per #22653 (comment))

vpn context menu hamburger menu
image image

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.46.86 Chromium: 107.0.5304.91 (Official Build) beta (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 11.7.1 (Build 20G918)

This should actually only be changed for Windows (since we don't have VPN on Linux); macOS should use Title Case, rather than Sentence case.

So I'm going to verify it based on the above.

VPN-button's context menu Brave VPN flyout menu
Screen Shot 2022-10-31 at 11 38 13 AM Screen Shot 2022-10-31 at 11 38 50 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment