Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not prompted to re-Allow enabling Brave's VPN Configuration until restart #22676

Closed
stephendonner opened this issue May 3, 2022 · 5 comments
Closed
Assignees
Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/vpn OS/Desktop OS/macOS QA/Test-Plan-Specified QA/Yes

Comments

@stephendonner
Copy link

Description

Not prompted to re-Allow enabling Brave's VPN Configuration until restart

Found while testing #22109.

Steps to Reproduce

  1. follow steps 1-18 on https://bravesoftware.slack.com/archives/CC5SA8CCB/p1651597201141019?thread_ts=1651597077.189229&cid=CC5SA8CCB
  2. when prompted to add VPN connections, click on Don't Allow
  3. click on the VPN icon in the toolbar

Actual result:

Screen Shot 2022-05-03 at 8 44 24 AM

You are shown the incorrect/incomplete error message, above; you don't get re-prompted until restart, nor do you get the error from the spec, shown below in Expected result.

Clicking Try again doesn't work either.

Expected result:

After clicking Don't Allow for the 1st time, clicking again on the VPN icon should show the below error. Toggling to CONNECTED/ON should re-prompt for the VPN-config addition to the OS

161843580-95d32353-e671-4f19-a607-7440b0b4bb21

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.39.89 Chromium: 101.0.4951.41 (Official Build) beta (x86_64)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS macOS Version 11.6.5 (Build 20G527)

cc @brave/qa-team

@stephendonner
Copy link
Author

cc @simonhong @bsclifton @nullhook

@LaurenWags
Copy link
Member

++ reproduced

@GeetaSarvadnya
Copy link

Windows don't prompt add VPN modal popup. Looks like macOS specific issue.

@spylogsster
Copy link

cannot reproduce, @stephendonner @GeetaSarvadnya can someone confirm on your side? thanks!

@spylogsster spylogsster self-assigned this Dec 12, 2022
@bsclifton
Copy link
Member

I'll close this out as stale - @stephendonner let's create a new issue if this still exists. Thanks!

@bsclifton bsclifton added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/vpn OS/Desktop OS/macOS QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

No branches or pull requests

5 participants