Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle not having permission to write config (macOS) #22109

Closed
Tracked by #15804
bsclifton opened this issue Apr 5, 2022 · 1 comment · Fixed by brave/brave-core#12175
Closed
Tracked by #15804

Handle not having permission to write config (macOS) #22109

bsclifton opened this issue Apr 5, 2022 · 1 comment · Fixed by brave/brave-core#12175
Assignees
@nullhook
Labels
feature/vpn OS/Desktop OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.39.x - Release

Comments

@bsclifton
Copy link
Member

bsclifton commented Apr 5, 2022 •
edited
Loading

Description

When trying to write the VPN profile to the user's machine, user is presented with this dialog
image

If the user picks Don't allow, the config is NOT written to networking and we can't use VPN.

Steps to Reproduce

  1. Fresh install of build with VPN
  2. Enable the proper flags
  3. Login to accounts website; restore VPN
  4. Click VPN button next to hamburger menu
  5. Toggle connection on
  6. See dialog (above) and click Don't allow

Actual result:

Nothing happens; user won't get presented this option again until they quit/relaunch

Expected result:

We should show a message like this:
image
@nullhook nullhook self-assigned this Apr 5, 2022
@nullhook nullhook mentioned this issue Apr 5, 2022
Merged
35 tasks
@bsclifton bsclifton mentioned this issue Apr 6, 2022
Closed
38 tasks
simonhong pushed a commit to brave/brave-core that referenced this issue Apr 6, 2022
@nullhook @simonhong
Added connect not allowed note on the main panel
ccf012a 
Fixes brave/brave-browser#22109
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 7, 2022
bsclifton pushed a commit to brave/brave-core that referenced this issue Apr 9, 2022
@nullhook @bsclifton
Added connect not allowed note on the main panel
a92f86e 
Fixes brave/brave-browser#22109
simonhong pushed a commit to brave/brave-core that referenced this issue Apr 11, 2022
@nullhook @simonhong
Added connect not allowed note on the main panel
0935c94 
Fixes brave/brave-browser#22109
@bsclifton bsclifton added this to the 1.39.x - Nightly milestone Apr 13, 2022
@stephendonner stephendonner mentioned this issue May 3, 2022
Closed
@stephendonner
Copy link

Marking this as QA Pass-macOS since I logged the follow-up issue (which I think should've been fixed in this one), here: #22676

Tested with

Brave 1.39.89 Chromium: 101.0.4951.41 (Official Build) beta (x86_64)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS macOS Version 11.6.5 (Build 20G527)

Will verify the fix for this issue along with/over in #22676.

@hffvld hffvld mentioned this issue Feb 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nullhook nullhook

Labels
feature/vpn OS/Desktop OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.39.x - Release
Development

Successfully merging a pull request may close this issue.

Remaining Desktop VPN work brave/brave-core
4 participants
@stephendonner @bsclifton @rebron @nullhook