Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacebar should work like clicks in Settings dialog #22732

Closed
stephendonner opened this issue May 7, 2022 · 1 comment · Fixed by brave/brave-core#13878
Closed

Spacebar should work like clicks in Settings dialog #22732

stephendonner opened this issue May 7, 2022 · 1 comment · Fixed by brave/brave-core#13878

Comments

@stephendonner
Copy link

stephendonner commented May 7, 2022

Description

Spacebar should work like clicks in Settings dialog

Steps to Reproduce

  1. install 1.39.92
  2. launch Brave
  3. set up VPN
  4. click on the VPN button
  5. click on the Settings (gear) icon
  6. tab to any of the 3 options (Contact technical support is the only one hooked up right now - see Hook Manage subscription link in Settings dialog up to the Accounts site #22694 and Hook up About Brave Firewall + VPN link in Settings dialog #22695)
  7. press spacebar

Actual result:

Nothing happens

Screen Shot 2022-05-06 at 7 07 55 PM

Expected result:

Pressing spacebar on a focused element should function like a click() event

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.39.92 Chromium: 101.0.4951.54 (Official Build) beta (x86_64)
Revision 67da1aeb32cedd27634ca6634fb79cbd85d3f0ab-refs/branch-heads/4951@{#1126}
OS macOS Version 11.6.5 (Build 20G527)

@nullhook @rebron @mattmcalister @brave/qa-team

@stephendonner
Copy link
Author

stephendonner commented Jul 1, 2022

Verified PASSED using

Brave 1.42.49 Chromium: 103.0.5060.70 (Official Build) nightly (x86_64)
Revision 1543faf9f70e61c6f6e9c01ff20a2e3cf2ad55dc-refs/branch-heads/5060_53@{#4}
OS macOS Version 11.6.7 (Build 20G630)

Followed my original steps to reproduce.

Confirmed I can open dialog links by navigation with tab and shift+tab, and opening with the spacebar

keyboard-navigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants