Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve race conditions in Rewards browser tests #22794

Closed
zenparsing opened this issue May 11, 2022 · 0 comments · Fixed by brave/brave-core#13383
Closed

Resolve race conditions in Rewards browser tests #22794

zenparsing opened this issue May 11, 2022 · 0 comments · Fixed by brave/brave-core#13383
Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Milestone
1.39.x - Release #2

Comments

@zenparsing
Copy link

It appears that there may be race conditions in some Rewards browser tests. In particular, rewards_p3a_browsertests.cc contains tests that call SetAdsEnabled without necessarily waiting until ads have been successfully enabled before calling FetchBalance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.39.x - Release #2
Development

Successfully merging a pull request may close this issue.

Fix flaky Rewards browser tests brave/brave-core
3 participants
@kjozwiak @rebron @zenparsing