Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky Rewards browser tests (uplift to 1.39.x) #13430

Merged
merged 2 commits into from
May 24, 2022
Merged

Fix flaky Rewards browser tests (uplift to 1.39.x) #13430

merged 2 commits into from
May 24, 2022

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented May 23, 2022 •
edited by kjozwiak
Loading

Uplift of #13383

Resolves brave/brave-browser#12605
Resolves brave/brave-browser#12607
Resolves brave/brave-browser#12632
Resolves brave/brave-browser#12704
Resolves brave/brave-browser#12986
Resolves brave/brave-browser#12987
Resolves brave/brave-browser#12988
Resolves brave/brave-browser#22794
Resolves brave/brave-browser#22865
Resolves brave/brave-browser#22866
Resolves brave/brave-browser#22867
Resolves brave/brave-browser#22868
Resolves brave/brave-browser#22869
Resolves brave/brave-browser#22870

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@zenparsing zenparsing requested a review from a team May 23, 2022 13:29
@zenparsing zenparsing requested a review from a team as a code owner May 23, 2022 13:29
@zenparsing zenparsing requested review from emerick and deeppandya and removed request for a team May 23, 2022 13:29
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label May 23, 2022
@zenparsing zenparsing removed the CI/storybook-url Deploy storybook and provide a unique URL for each build label May 23, 2022
@zenparsing zenparsing removed their assignment May 23, 2022
@kjozwiak kjozwiak added this to the 1.39.x - Release milestone May 24, 2022
@zenparsing zenparsing force-pushed the ksmith-fix-rewardstests-1.39.x branch from ecd7d97 to 37feed3 Compare May 24, 2022 14:09
kjozwiak
kjozwiak approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.39.x approved 👍

@kjozwiak kjozwiak merged commit 658c4f6 into 1.39.x May 24, 2022
@kjozwiak kjozwiak deleted the ksmith-fix-rewardstests-1.39.x branch May 24, 2022 23:03
This was referenced May 25, 2022
Closed
Closed
@bsclifton
Copy link
Member

Resolves brave/brave-browser#22983
Resolves brave/brave-browser#22982
Resolves brave/brave-browser#22981
Resolves brave/brave-browser#22980
Resolves brave/brave-browser#22979
Resolves brave/brave-browser#22978

This was referenced May 25, 2022
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.39.x - Release #2
Development

Successfully merging this pull request may close these issues.
3 participants
@zenparsing @bsclifton @kjozwiak