Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting a test network and disabling it causes the network dropdown to not fallback to default network #22953

Closed
srirambv opened this issue May 20, 2022 · 2 comments

Comments

@srirambv
Copy link
Contributor

Description

Setting a test network and disabling it causes the network dropdown to not fallback to default network

Steps to Reproduce

  1. Enable test networks to be shown
  2. Select any of the test network
  3. Go back to settings and disable show test networks
  4. Reload the wallet page, test network is removed and doesn't fall back to default network

Actual result:

TestNetwork.mov

Expected result:

Should fall back to default network or the mainnet for the selected test network

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.41.4 Chromium: 102.0.5005.50 (Official Build) nightly (64-bit)
Revision f6e2cf8f59ec714bdcff8499991d55898875f287-refs/branch-heads/5005@{#648}
OS Windows 11 Version 22H2 (Build 22621.1)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel

@srirambv srirambv added this to Web3 May 20, 2022
@Douglashdaniel Douglashdaniel self-assigned this May 20, 2022
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 May 20, 2022
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label May 20, 2022
@Douglashdaniel Douglashdaniel added feature/web3/wallet/core and removed front-end-change This task is a front end task and doesn't need any C++ changes labels Jul 1, 2022
@Douglashdaniel
Copy link

This should be handled on the core-end!

@Douglashdaniel Douglashdaniel removed their assignment Jul 1, 2022
@Douglashdaniel Douglashdaniel moved this from In Progress to Backlog in Web3 Jul 1, 2022
@supermassive supermassive self-assigned this Nov 17, 2022
@Douglashdaniel
Copy link

The Show Test networks pref was removed a while back, closing as Invalid

@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants