Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add showTestNetworks user pref in Settings #21650

Closed
Douglashdaniel opened this issue Mar 14, 2022 · 4 comments · Fixed by brave/brave-core#13098
Closed

Add showTestNetworks user pref in Settings #21650

Douglashdaniel opened this issue Mar 14, 2022 · 4 comments · Fixed by brave/brave-core#13098

Comments

@Douglashdaniel
Copy link

Description

We need a showTestNetworks: boolean user pref in brave://settings/wallet to allow users to decide if they want to see Test Networks as an option in their wallet. Could be just a boolean value and the Front-end can filter out those networks or vice versa if we want to handle on the backend.

@Douglashdaniel Douglashdaniel added feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Mar 14, 2022
@Douglashdaniel Douglashdaniel changed the title Add Show Test Networks in Settings Add showTestNetworks user pref in Settings Mar 14, 2022
@srirambv
Copy link
Contributor

Does Android inherit this changes or should that be done separately?

cc: @SergeyZhukovsky @wchen342 @Pavneet-Sing

@SergeyZhukovsky
Copy link
Member

@srirambv it's a front-end work, need to be done separately on mobile

@kjozwiak
Copy link
Member

The above requires 1.39.110 or higher for 1.39.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented May 23, 2022

Brave 1.39.111 Chromium: 102.0.5005.61 (Official Build) (64-bit)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS ☑️ Linux ☑️ Windows 11 Version 22H2
(Build 22621.1)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#13098
  • Verified new setting called Show test networks is available under brave://settings/wallet/networks
  • Verified setting is disabled by default hence no test network is shown by default
  • Verified enabling the settings shows all test networks for default networks(Solana/Ethereum)
  • Encountered #22953
Show test networks Off
Show test networks On
Test networks shown network selector
Test networks not visible on network selector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment