Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add toggle to show/hide test networks in wallet settings #5646

Closed
StephenHeaps opened this issue Jul 5, 2022 · 1 comment · Fixed by #5656
Closed

Add toggle to show/hide test networks in wallet settings #5646

StephenHeaps opened this issue Jul 5, 2022 · 1 comment · Fixed by #5656
Assignees
@StephenHeaps
Labels
enhancement Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes
Milestone
1.41

Comments

@StephenHeaps
Copy link
Contributor

Description:

Add a toggle in Wallet settings to show/hide test networks.

ref: brave/brave-browser#21650
@StephenHeaps StephenHeaps added this to Web3 Jul 5, 2022
@StephenHeaps StephenHeaps self-assigned this Jul 7, 2022
@StephenHeaps StephenHeaps moved this to In Progress in Web3 Jul 7, 2022
@StephenHeaps StephenHeaps mentioned this issue Jul 7, 2022
Merged
7 tasks
StephenHeaps added a commit that referenced this issue Jul 11, 2022
@StephenHeaps
Fix #5646: Show/hide test networks toggle (#5656)
e35d768 
* Add toggle to `CustomNetworkListView` in Wallet settings to show/hide test networks. Test networks hidden by default.

* Show currently selected network in the picker. Possible when selecting a test network, then either changing the show network toggle to off or updating to app version with test networks hidden by default).
Repository owner moved this from In Progress to Done in Web3 Jul 11, 2022
@iccub iccub added this to the 1.41 milestone Jul 11, 2022
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.41 (22.7.11.19)

  • Verified a new setting for Show test networks is shown under Wallet ->Networks
  • Verified the settings is disabled by default on clean install or on upgrade
  • Verified test networks are only shown when the settings is enabled
  • Verified if the current network is set to a Test network, post upgrade it is retained and remaining networks are removed
  • Encountered #5687 on iPad
iPhone 7+ (iOS 14.8.1) iPhone XR (iOS 15.4.1) iPad Pro (iOS 16 Beta 3)
iPhone.7+.MP4
iPhone.XR.MP4
iPad.MP4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
enhancement Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes
Projects
Web3
Archived in project
Milestone
1.41
Development

Successfully merging a pull request may close this issue.

Fix #5646: Show/hide test networks toggle brave/brave-ios
3 participants
@StephenHeaps @iccub @srirambv