feat(wallet): Added Show Test Networks Pref #13098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI/storybook-url
Douglashdaniel
force-pushed
the
show-test-networks-pref
branch
from
28831e5 to
38006ee
Compare
|
A Storybook has been deployed to preview UI for the latest push |
supermassive
requested changes
Apr 21, 2022
| @@ -512,6 +512,11 @@ void BraveWalletService::SetDefaultBaseCryptocurrency( | |||
| } | |||
| } | |||
|
|
|||
| void BraveWalletService::GetShowWalletTestNetworks( | |||
There was a problem hiding this comment.
Please add a test for this method being backed by a pref.
There was a problem hiding this comment.
There was a problem hiding this comment.
I meant it should cover case when changing pref changes service method outcome;)
So please add smth like this
diff --git a/browser/brave_wallet/brave_wallet_service_unittest.cc b/browser/brave_wallet/brave_wallet_service_unittest.cc
index 93c5311959..7e686898b5 100644
--- a/browser/brave_wallet/brave_wallet_service_unittest.cc
+++ b/browser/brave_wallet/brave_wallet_service_unittest.cc
@@ -459,6 +459,18 @@ class BraveWalletServiceUnitTest : public testing::Test {
return default_cryptocurrency;
}
+ bool GetShowWalletTestNetworks() {
+ base::RunLoop run_loop;
+ bool show_wallet_test_networks;
+ service_->GetShowWalletTestNetworks(
+ base::BindLambdaForTesting([&](bool b) {
+ show_wallet_test_networks = b;
+ run_loop.Quit();
+ }));
+ run_loop.Run();
+ return show_wallet_test_networks;
+ }
+
void SimulateOnGetImportInfo(const std::string& new_password,
bool result,
const ImportInfo& info,
@@ -1084,7 +1096,10 @@ TEST_F(BraveWalletServiceUnitTest, GetAndSetDefaultBaseCryptocurrency) {
TEST_F(BraveWalletServiceUnitTest, GetShowWalletTestNetworks) {
// Default value for kShowWalletTestNetworks should be false
EXPECT_FALSE(GetPrefs()->GetBoolean(kShowWalletTestNetworks));
- EXPECT_FALSE(GetShowWalletTestNetworks(GetPrefs()));
+ EXPECT_FALSE(GetShowWalletTestNetworks());
+
+ GetPrefs()->SetBoolean(kShowWalletTestNetworks, true);
+ EXPECT_TRUE(GetShowWalletTestNetworks());
}
TEST_F(BraveWalletServiceUnitTest, EthAddRemoveSetUserAssetVisible) {
Marking as approved.
There was a problem hiding this comment.
Gotcha!
Updated, thank you for the help! 😎
Douglashdaniel
force-pushed
the
show-test-networks-pref
branch
from
38006ee to
4498eb7
Compare
|
A Storybook has been deployed to preview UI for the latest push |
Douglashdaniel
force-pushed
the
show-test-networks-pref
branch
from
4498eb7 to
eafe2a1
Compare
|
A Storybook has been deployed to preview UI for the latest push |
Douglashdaniel
force-pushed
the
show-test-networks-pref
branch
from
eafe2a1 to
c76a0e7
Compare
|
A Storybook has been deployed to preview UI for the latest push |
supermassive
approved these changes
Apr 25, 2022
| @@ -512,6 +512,11 @@ void BraveWalletService::SetDefaultBaseCryptocurrency( | |||
| } | |||
| } | |||
|
|
|||
| void BraveWalletService::GetShowWalletTestNetworks( | |||
There was a problem hiding this comment.
I meant it should cover case when changing pref changes service method outcome;)
So please add smth like this
diff --git a/browser/brave_wallet/brave_wallet_service_unittest.cc b/browser/brave_wallet/brave_wallet_service_unittest.cc
index 93c5311959..7e686898b5 100644
--- a/browser/brave_wallet/brave_wallet_service_unittest.cc
+++ b/browser/brave_wallet/brave_wallet_service_unittest.cc
@@ -459,6 +459,18 @@ class BraveWalletServiceUnitTest : public testing::Test {
return default_cryptocurrency;
}
+ bool GetShowWalletTestNetworks() {
+ base::RunLoop run_loop;
+ bool show_wallet_test_networks;
+ service_->GetShowWalletTestNetworks(
+ base::BindLambdaForTesting([&](bool b) {
+ show_wallet_test_networks = b;
+ run_loop.Quit();
+ }));
+ run_loop.Run();
+ return show_wallet_test_networks;
+ }
+
void SimulateOnGetImportInfo(const std::string& new_password,
bool result,
const ImportInfo& info,
@@ -1084,7 +1096,10 @@ TEST_F(BraveWalletServiceUnitTest, GetAndSetDefaultBaseCryptocurrency) {
TEST_F(BraveWalletServiceUnitTest, GetShowWalletTestNetworks) {
// Default value for kShowWalletTestNetworks should be false
EXPECT_FALSE(GetPrefs()->GetBoolean(kShowWalletTestNetworks));
- EXPECT_FALSE(GetShowWalletTestNetworks(GetPrefs()));
+ EXPECT_FALSE(GetShowWalletTestNetworks());
+
+ GetPrefs()->SetBoolean(kShowWalletTestNetworks, true);
+ EXPECT_TRUE(GetShowWalletTestNetworks());
}
TEST_F(BraveWalletServiceUnitTest, EthAddRemoveSetUserAssetVisible) {
Marking as approved.
Douglashdaniel
force-pushed
the
show-test-networks-pref
branch
from
c76a0e7 to
93ceba5
Compare
Douglashdaniel
force-pushed
the
show-test-networks-pref
branch
from
93ceba5 to
352a4ea
Compare
|
A Storybook has been deployed to preview UI for the latest push |
josheleonard
approved these changes
Apr 25, 2022
Douglashdaniel
added a commit
that referenced
this pull request
May 19, 2022
feat(wallet): Added Show Test Networks Pref
7 tasks
|
Verification for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a
Show test networkspref inbrave://setting/walletand passed toWalletUIResolves brave/brave-browser#21650
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Screen.Recording.2022-04-20.at.10.31.55.AM.mov