Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Tor implementation to retain consistent profile #2307

Closed
tildelowengrimm opened this issue Nov 30, 2018 · 7 comments · Fixed by brave/brave-core#3319
Closed

Refactor Tor implementation to retain consistent profile #2307

tildelowengrimm opened this issue Nov 30, 2018 · 7 comments · Fixed by brave/brave-core#3319
Assignees
Labels
feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. feature/tor priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@tildelowengrimm
Copy link
Contributor

Because private windows with Tor are implemented using guest windows, they don't share anything with the regular profile. Settings aren't inherited, bookmarks aren't present, extensions aren't available, and so on. Instead, windows with Tor should match regular private windows in their interactions with the profile — generally read-only unless someone makes an affirmative action like adding a bookmark.

@tildelowengrimm tildelowengrimm added feature/tor priority/P4 Planned work. We expect to get to it "soon". feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. labels Nov 30, 2018
@tildelowengrimm tildelowengrimm added this to the 1.x Backlog milestone Nov 30, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@durch
Copy link

durch commented May 21, 2019

@tomlowenthal looking at unblocking #1677, I'd be willing to sink considerable time into making this happen. Just not sure what would be the best place to start, looking at both the tor_profile_service_factory and the brave_profile_manager I can't figure out where the decision to go with the guest profile is made, a pointer in the right direction would be much appreciated :)

@yrliou yrliou self-assigned this May 22, 2019
@yrliou
Copy link
Member

yrliou commented May 22, 2019

@durch Hi, just a heads up that I am actively working on refactoring our tor profile stuff to make it align with the incognito profile (profile behind private window) at the moment. #1677 should be unblocked after this is done, thanks!

@durch
Copy link

durch commented May 23, 2019

Glad to hear that, is there a branch, or a PR I could follow? Just trying to get some ideas around the timeline.

@yrliou
Copy link
Member

yrliou commented May 23, 2019

@durch At the moment it's still a working in progress in the local, but I will update here if a remote branch or PR is created for you and anyone who is interested to follow the progress, thanks!

@durch
Copy link

durch commented May 23, 2019

That sounds awesome @yrliou, thank you!

@tildelowengrimm tildelowengrimm added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Jun 16, 2019
@riastradh-brave riastradh-brave added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jul 25, 2019
@yrliou
Copy link
Member

yrliou commented Oct 3, 2019

With brave/brave-core#3319 merged, we now have settings and bookmarks from the original regular profile, extensions are not ready yet, I'll open a new issue to capture that.

@yrliou yrliou added this to the 0.72.x - Nightly milestone Oct 3, 2019
@btlechowski
Copy link

btlechowski commented Oct 28, 2019

Verification passed on

Brave 0.72.110 Chromium: 78.0.3904.70 (Official Build) dev (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#3319
Verified bookmarks and global settings are shared between normal and tor window. Extensions are not shared yet per #2307 (comment)
Verified that brave://settings page is redirected to normal window.
Verified on Clean profile and on upgrade from 0.70.x

Verification passed on

Brave 1.1.1 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave 1.1.2 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. feature/tor priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
8 participants