-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Tor implementation to retain consistent profile #2307
Comments
@tomlowenthal looking at unblocking #1677, I'd be willing to sink considerable time into making this happen. Just not sure what would be the best place to start, looking at both the |
Glad to hear that, is there a branch, or a PR I could follow? Just trying to get some ideas around the timeline. |
@durch At the moment it's still a working in progress in the local, but I will update here if a remote branch or PR is created for you and anyone who is interested to follow the progress, thanks! |
That sounds awesome @yrliou, thank you! |
With brave/brave-core#3319 merged, we now have settings and bookmarks from the original regular profile, extensions are not ready yet, I'll open a new issue to capture that. |
Verification passed on
Verified test plan from brave/brave-core#3319 Verification passed on
Verified passed with
|
Because private windows with Tor are implemented using guest windows, they don't share anything with the regular profile. Settings aren't inherited, bookmarks aren't present, extensions aren't available, and so on. Instead, windows with Tor should match regular private windows in their interactions with the profile — generally read-only unless someone makes an affirmative action like adding a bookmark.
The text was updated successfully, but these errors were encountered: