Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate tabs shouldn't be possible for Manage subscription flows #23100

Closed
stephendonner opened this issue May 27, 2022 · 1 comment · Fixed by brave/brave-core#13882
Closed

Comments

@stephendonner
Copy link

Description

Duplicate tabs shouldn't be possible for Manage subscription flows

Steps to Reproduce

  1. install 1.41.19
  2. launch Brave
  3. set up VPN
  4. click on the VPN button
  5. click on the Settings / gear icon
  6. click Manage subscription
  7. note that https://account.brave.software/ opens up in a new tab
  8. repeat 4-7

Actual result:

Duplicate tabs with https://account.brave.software/ keep being opened for each repeated set of the above

example example example example
Screen Shot 2022-05-27 at 2 44 04 AM Screen Shot 2022-05-27 at 2 44 08 AM Screen Shot 2022-05-27 at 2 44 19 AM Screen Shot 2022-05-27 at 2 44 22 AM

Expected result:

No duplicate tabs opened with https://account.brave.software/

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.41.19 Chromium: 102.0.5005.61 (Official Build) nightly (x86_64)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS macOS Version 11.6.6 (Build 20G624)

/cc @simonhong @bsclifton @rebron @nullhook @brave/qa-team

@stephendonner
Copy link
Author

stephendonner commented Jul 13, 2022

Verified PASSED using

Brave 1.42.62 Chromium: 103.0.5060.114 (Official Build) beta (x86_64)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS macOS Version 11.6.7 (Build 20G630)

Followed my original steps to reproduce.

Confirmed the initial tab for VPN opens Manage subscription in a single tab.

vpn-issue

Filed #24048 because this still happens occasionally (still working on reduced steps) and with a new window


Verification PASSED on

Brave | 1.42.78 Chromium: 103.0.5060.134 (Official Build) beta (64-bit)
-- | --
Revision | 8ec6fce403b3feb0869b0732eda8bd95011d333c-refs/branch-heads/5060@{#1262}
OS | Windows 10 Version 21H2 (Build 19044.1826)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment