Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Brave Rewards icon option requires a left-click on the Brave Rewards icon every time browser is restarted #23124

Closed
Tonev opened this issue May 28, 2022 · 3 comments
Assignees

Comments

@Tonev
Copy link
Contributor

Tonev commented May 28, 2022

Description

Users can't use the new Hide Brave Rewards icon option without an extra left-click on the icon in advance. This is required after every browser restart.

Steps to Reproduce

  1. Clean user profile in Brave Beta or Brave Nightly.
  2. Right-click on the Brave Rewards icon in the address bar.

Actual result:

The Hide Brave Rewards icon option doesn't appear. For users to be able to use the option, they'll have to left-click on the Brave Rewards icon in the address bar, and then they'll be able to hide the icon through a right-click until they close the browser.

Expected result:

I would expect to be able to use the Hide Brave Rewards icon option with one click every time.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.40.75 Chromium: 102.0.5005.61 (Official Build) beta (64-bit)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS Windows 10 Version 21H2 (Build 19044.1706)
Brave 1.41.20 Chromium: 102.0.5005.61 (Official Build) nightly (64-bit)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS Windows 10 Version 21H2 (Build 19044.1706)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CC: @mkarolin @rebron

@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 2, 2022
@Miyayes
Copy link
Collaborator

Miyayes commented Jun 8, 2022

May be resolved for free with #22423

@Miyayes Miyayes added priority/P5 Not scheduled. Don't anticipate work on this any time soon. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 8, 2022
@Tonev
Copy link
Contributor Author

Tonev commented Jun 11, 2022

@Miyayes

Isn't the linked issue supposed to introduce changes only when Brave Rewards is enabled?

@mkarolin
Copy link
Contributor

mkarolin commented Dec 6, 2022

This was addressed via #22423

@mkarolin mkarolin closed this as completed Dec 6, 2022
@mkarolin mkarolin added this to the 1.43.x - Release milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants