-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not including wallet providers for 3p iframes breaks ImmutableX #23142
Comments
Connect https://link.x.immutable.com Modify hosts file to have: Note: Granting permission on z.com does not give you permission on y.z.com and vice versa. They are treated differently. The below is only for what is allowed to prompt for permission. I break down how it works into 3 sections:
Original Brave (before 1.39.x) and Current MetaMask:Test case 1)
Test case 2)
1.39.x (current release)Test case 1)
Test case 2)
With implemented changesTest case 1)
Test case 2)
|
No longer valid with brave/brave-core#13783 |
Reverting brave/brave-core#13268 locally fixes the problem.
Introduced by issue #22686
Steps to reproduce:
Actual results:
No wallet detected error shows up
Expected results:
It pops up Brave Wallet
I did some logging:
And get:
The text was updated successfully, but these errors were encountered: