Allow permission requests within the same eTLD+1 #13564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
reviewed
Jun 1, 2022
components/permissions/contexts/brave_wallet_permission_context.cc
Outdated
Show resolved
Hide resolved
bbondy
force-pushed
the
ethereum-3p-context
branch
from
514f0c0
to
854ef4a
Compare
goodov
reviewed
Jun 2, 2022
| EXPECT_FALSE(responses.empty()); | ||
| })); | ||
|
|
||
| content::RunAllTasksUntilIdle(); |
There was a problem hiding this comment.
pls use base::RunLoop instead and call Quit in the lambda.
| })); | ||
|
|
||
| content::RunAllTasksUntilIdle(); | ||
| EXPECT_FALSE(IsPendingGroupedRequestsEmpty(cases[i].type)) << "case: " << i; |
There was a problem hiding this comment.
can also write it like this, seems okay to distinguish cases by the wallet address:
for (const auto& case : cases) {
SCOPED_TRACE(testing::PrintToString(case.addresses));
...
There was a problem hiding this comment.
I didn't know about that, thanks!
Fixed in 3e1a254
bbondy
force-pushed
the
ethereum-3p-context
branch
from
854ef4a
to
9d0ff1f
Compare
bbondy
commented
Jun 3, 2022
bbondy
force-pushed
the
ethereum-3p-context
branch
2 times, most recently
from
6a55c3e
to
3e1a254
Compare
|
FYI - I removed some debug prints and updated comments to reference the latest hash. |
goodov
previously approved these changes
Jun 6, 2022
bbondy
force-pushed
the
ethereum-3p-context
branch
from
3e1a254
to
df1ef78
Compare
diracdeltas
reviewed
Jun 6, 2022
| original_requesting_origin == url::Origin::Create(embedding_origin)) { | ||
| net::registry_controlled_domains::SameDomainOrHost( | ||
| original_requesting_origin, url::Origin::Create(embedding_origin), | ||
| net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES)) { |
There was a problem hiding this comment.
just wanted to double check - embedding_origin is the top level (main frame) origin as opposed to the parent origin? ex: if a.com embeds b.com which embeds c.com and the requesting origin is c.com, embedding origin is a.com not b.com.
|
Closing in favor of #13783 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#23142
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: