Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle to hide networks in wallet UI #23208

Closed
supermassive opened this issue Jun 2, 2022 · 2 comments · Fixed by brave/brave-core#13710
Closed

Toggle to hide networks in wallet UI #23208

supermassive opened this issue Jun 2, 2022 · 2 comments · Fixed by brave/brave-core#13710
Assignees
@supermassive
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.41.x - Release

Comments

@supermassive
Copy link

Wallet network settings should have a per-network toggle to control network visibility in wallet ui.
@supermassive supermassive added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Jun 2, 2022
@supermassive supermassive self-assigned this Jun 2, 2022
@yrliou yrliou added this to Web3 Jun 2, 2022
@jamesmudgett jamesmudgett added priority/P4 Planned work. We expect to get to it "soon". priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 7, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jun 7, 2022
@jamesmudgett jamesmudgett added this to the 1.41.x - Nightly milestone Jun 7, 2022
@jamesmudgett jamesmudgett mentioned this issue Jun 7, 2022
Closed
This was referenced Jun 10, 2022
Merged
Open
@supermassive supermassive removed the OS/Android Fixes related to Android browser functionality label Jun 13, 2022
Repository owner moved this from Backlog to Done in Web3 Jun 13, 2022
@supermassive supermassive added QA/Yes release-notes/include and removed priority/P4 Planned work. We expect to get to it "soon". labels Jun 23, 2022
@Uni-verse
Copy link
Contributor

Verification PASSED using

Brave	1.41.91 Chromium: 103.0.5060.114 (Official Build) beta (64-bit) 
Revision	a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS	Windows 11 Version 21H2 (Build 22000.318)

Using STR/Test Plan in brave/brave-core#13710 (comment)

  • Confirmed there is now an "Eye" button for each network to toggle its visibility in wallet ui.
  • Confirmed the active network is marked with bold and always visible.
  • Confirmed user is able to toggle visibility on non-preloaded networks and custom networks manually added.
  • Confirmed when network is as as active, the eye icon is not shown.
  • Confirmed eye icon shows correct state for visible/hidden setting.
  • Confirmed changing the active network in the wallet panel will be reflect in the brave://settings/wallet/networks page (user has to reload page)
Example Example Example
Screen Shot 2022-07-08 at 11 59 46 AM Screen Shot 2022-07-08 at 12 03 19 PM Screen Shot 2022-07-08 at 11 59 06 AM

@Uni-verse
Copy link
Contributor

Verification PASSED using

Brave	1.41.91 Chromium: 103.0.5060.114 (Official Build) beta (64-bit) 
Revision	a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS	Linux (Debian version 11)

Using STR/Test Plan in brave/brave-core#13710 (comment)

  • Confirmed there is now an "Eye" button for each network to toggle its visibility in wallet ui.
  • Confirmed the active network is marked with bold and always visible.
  • Confirmed user is able to toggle visibility on non-preloaded networks and custom networks manually added.
  • Confirmed when network is as as active, the eye icon is not shown.
  • Confirmed eye icon shows correct state for visible/hidden setting.
  • Confirmed changing the active network in the wallet panel will be reflect in the brave://settings/wallet/networks page (user has to reload page)

Screen Shot 2022-07-08 at 2 00 49 PM

@LaurenWags LaurenWags mentioned this issue Jul 11, 2022
Closed
@bbondy bbondy changed the title Toggle to hide networks in wallet ui Toggle to hide networks in wallet UI Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.41.x - Release
Development

Successfully merging a pull request may close this issue.

Toggle network visibility brave/brave-core
4 participants
@supermassive @jamesmudgett @yrliou @Uni-verse