Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow editing properties of known chains #23207

Closed
supermassive opened this issue Jun 2, 2022 · 2 comments · Fixed by brave/brave-core#13644
Closed

Allow editing properties of known chains #23207

supermassive opened this issue Jun 2, 2022 · 2 comments · Fixed by brave/brave-core#13644
Assignees
@supermassive
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.41.x - Release

Comments

@supermassive
Copy link

Continuing #20517

  • Known networks should not be removable.
  • Custom networks overriding known ones should be resettable to known.
  • Custom networks overriding known ones should take place of known ones in lists(settings and wallet).
@supermassive supermassive self-assigned this Jun 2, 2022
@supermassive supermassive mentioned this issue Jun 2, 2022
Closed
@supermassive supermassive added the OS/Android Fixes related to Android browser functionality label Jun 2, 2022
@yrliou yrliou added the feature/web3/wallet Integrating Ethereum+ wallet support label Jun 2, 2022
@yrliou yrliou added this to Web3 Jun 2, 2022
@supermassive supermassive mentioned this issue Jun 7, 2022
Merged
25 tasks
@jamesmudgett
Copy link

Also related #23208 need a feature to hide known chain

@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 7, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jun 7, 2022
@supermassive supermassive added release-notes/include and removed OS/Android Fixes related to Android browser functionality labels Jun 8, 2022
Repository owner moved this from Backlog to Done in Web3 Jun 9, 2022
@supermassive supermassive added this to the 1.41.x - Nightly milestone Jun 9, 2022
This was referenced Jun 10, 2022
Closed
Open
@srirambv
Copy link
Contributor

Brave 1.41.82 Chromium: 103.0.5060.66 (Official Build) beta (64-bit)
Revision 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.708) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#13644
  • Verified known/pre-loaded networks can't be removed
  • Verified known/pre-loaded networks can be edited
  • Verified known/pre-loaded networks that are edited can be reset to defaults
  • Verified known/pre-loaded networks that are edited can be set as default network
  • Verified known/pre-loaded networks that are edited updates the network name on panel and on portfolio
23207-Linux.mp4
23207-Windows.mp4
23207-macOS.mov

@LaurenWags LaurenWags mentioned this issue Jul 11, 2022
Closed
@bbondy bbondy changed the title Edit settings of known chains Allow editing properties of known chains Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.41.x - Release
Development

Successfully merging a pull request may close this issue.

Edit known networks brave/brave-core
4 participants
@supermassive @jamesmudgett @yrliou @srirambv