Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize twitter.com as a Greaselion url #23332

Closed
emerick opened this issue Jun 8, 2022 · 2 comments · Fixed by brave/brave-core#13689
Closed

Recognize twitter.com as a Greaselion url #23332

emerick opened this issue Jun 8, 2022 · 2 comments · Fixed by brave/brave-core#13689

Comments

@emerick
Copy link
Contributor

emerick commented Jun 8, 2022

In our extension API adapter, the isGreaselionURL function seems to be missing an entry for twitter.com. Based on inspection of the code it seems that this doesn't cause an error per se (just some unnecessary work) but we should add it in there for consistency.

@emerick emerick self-assigned this Jun 8, 2022
@emerick emerick added this to the 1.41.x - Nightly milestone Jun 8, 2022
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 13, 2022
@LaurenWags
Copy link
Member

LaurenWags commented Jun 13, 2022

Verified using

Brave | 1.41.59 Chromium: 103.0.5060.42 (Official Build) nightly (x86_64)
-- | --
Revision | de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS | macOS Version 12.4 (Build 21F79)

Verified test plan from brave/brave-core#13689 (comment)

Using Staging env for below cases:

  • Confirmed verified twitter creators still displayed as expected in the panel
    • Confirmed if verified and have a custom image, the custom image is displayed on the panel
    • Confirmed if verified and do not have a custom image, the creator's twitter image is displayed on the panel
  • Confirmed unverified twitter creators still displayed as expected in the panel
  • Confirmed able to tip verified twitter creators and the tip is shown as expected on the panel summary, balance decreases as expected, etc
  • Confirmed able to set up a monthly tip for a verified twitter creator and the panel reflects the selected amount for the tip
  • Confirmed verified twitter creators can be added to auto contribution list and the attention % displays on the panel as expected
  • Confirmed unverified twitter creators can be added to auto contribution list and the attention % displays on the panel as expected
Verified Example (custom image) Verified Example (added to AC list) Verified Example (no custom image) Unverified Example (uses default twitter image) Unverified Example (added to AC list)
1 2 5 3 4

Additionally, did some navigation checks to ensure panel showed correct creator info:

  • Visited several twitter pages in succession and then used back/forward browser buttons to navigate through the visited pages. Confirmed the panel showed the expected twitter user info each time.
  • Repeated above test while logged in to twitter. Confirmed the panel showed the expected twitter user info each time.
Brave | 1.41.77 Chromium: 103.0.5060.53 (Official Build) beta (x86_64)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | macOS Version 12.4 (Build 21F79)
  • Visited several twitter (and non-twitter) pages in various tabs/windows. Visit these twitter (and non-twitter) tabs/windows in various orders, opening the panel to confirm the expected creator info (twitter, non-twitter, verified, non-verified) is shown as expected each time.
  • Repeated above test while logged in to twitter. Confirmed the panel showed the expected creator info (twitter, non-twitter, verified, non-verified) is shown as expected each time.

Verification PASSED on


Brave | 1.41.77 Chromium: 103.0.5060.53 (Official Build) beta (64-bit)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | Windows 10 Version 21H2 (Build 19044.1766)

Verified test plan from brave/brave-core#13689 (comment)
Logged #23665

Using Staging env for below cases:

  • Confirmed verified twitter creators still displayed as expected in the panel
    • Confirmed if verified and have a custom image, the custom image is displayed on the panel
    • Confirmed if verified and do not have a custom image, the creator's twitter image is displayed on the panel
  • Confirmed unverified twitter creators still displayed as expected in the panel
  • Confirmed able to tip verified twitter creators and the tip is shown as expected on the panel summary, balance decreases as expected, etc
  • Confirmed able to set up a monthly tip for a verified twitter creator and the panel reflects the selected amount for the tip
  • Confirmed verified twitter creators can be added to auto contribution list and the attention % displays on the panel as expected
  • Confirmed unverified twitter creators can be added to auto contribution list and the attention % displays on the panel as expected
Verified Example (custom image) Verified Example (added to AC list) Verified Example (no custom image) Unverified Example (uses default twitter image) Unverified Example (added to AC list) AC table
image image image image image image

Additionally, did some navigation checks to ensure panel showed correct creator info:

  • Visited several twitter pages in succession and then used back/forward browser buttons to navigate through the visited pages. Confirmed the panel showed the expected twitter user info each time.

  • Repeated above test while logged in to twitter. Confirmed the panel showed the expected twitter user info each time.

  • Visited several twitter (and non-twitter) pages in various tabs/windows. Visit these twitter (and non-twitter) tabs/windows in various orders, opening the panel to confirm the expected creator info (twitter, non-twitter, verified, non-verified) is shown as expected each time.

  • Repeated above test while logged in to twitter. Confirmed the panel showed the expected creator info (twitter, non-twitter, verified, non-verified) is shown as expected each time.

@stephendonner
Copy link

stephendonner commented Jun 30, 2022

Verification PASSED using

Brave 1.41.86 Chromium: 103.0.5060.66 (Official Build) beta (64-bit)
Revision 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS Linux

Verified test plan from brave/brave-core#13689 (comment)

Using Staging env for below cases:

  • Confirmed verified twitter creators still displayed as expected in the panel
    • Confirmed if verified and have a custom image, the custom image is displayed on the panel
    • Confirmed if verified and do not have a custom image, the creator's twitter image is displayed on the panel
  • Confirmed unverified twitter creators still displayed as expected in the panel
  • Confirmed able to tip verified twitter creators and the tip is shown as expected on the panel summary, balance decreases as expected, etc
  • Confirmed able to set up a monthly tip for a verified twitter creator and the panel reflects the selected amount for the tip
  • Confirmed verified twitter creators can be added to auto contribution list and the attention % displays on the panel as expected
  • Confirmed unverified twitter creators can be added to auto contribution list and the attention % displays on the panel as expected
Verified Example (custom image) Verified Example (added to AC list) Verified Example (no custom image) Unverified Example (uses default twitter image) Unverified Example (added to AC list) AC list
Screen Shot 2022-06-30 at 11 36 51 AM Screen Shot 2022-06-30 at 11 38 22 AM Screen Shot 2022-06-30 at 11 39 11 AM Screen Shot 2022-06-30 at 11 40 23 AM Screen Shot 2022-06-30 at 11 41 10 AM Screen Shot 2022-06-30 at 12 17 27 PM

Additionally, did some navigation checks to ensure panel showed correct creator info:

Visited several twitter pages in succession and then used back/forward browser buttons to navigate through the visited pages. Confirmed the panel showed the expected twitter user info each time.

Repeated above test while logged in to twitter. Confirmed the panel showed the expected twitter user info each time.

Visited several twitter (and non-twitter) pages in various tabs/windows. Visit these twitter (and non-twitter) tabs/windows in various orders, opening the panel to confirm the expected creator info (twitter, non-twitter, verified, non-verified) is shown as expected each time.

Repeated above test while logged in to twitter. Confirmed the panel showed the expected creator info (twitter, non-twitter, verified, non-verified) is shown as expected each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment