-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognize twitter.com as a Greaselion url #23332
Comments
Verified using
Verified test plan from brave/brave-core#13689 (comment) Using Staging env for below cases:
Additionally, did some navigation checks to ensure panel showed correct creator info:
Verification PASSED on
Verified test plan from brave/brave-core#13689 (comment) Using Staging env for below cases:
Additionally, did some navigation checks to ensure panel showed correct creator info:
|
Verification
|
Brave | 1.41.86 Chromium: 103.0.5060.66 (Official Build) beta (64-bit) |
---|---|
Revision | 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066} |
OS | Linux |
Verified test plan from brave/brave-core#13689 (comment)
Using Staging env for below cases:
- Confirmed verified twitter creators still displayed as expected in the panel
- Confirmed if verified and have a custom image, the custom image is displayed on the panel
- Confirmed if verified and do not have a custom image, the creator's twitter image is displayed on the panel
- Confirmed unverified twitter creators still displayed as expected in the panel
- Confirmed able to tip verified twitter creators and the tip is shown as expected on the panel summary, balance decreases as expected, etc
- Confirmed able to set up a monthly tip for a verified twitter creator and the panel reflects the selected amount for the tip
- Confirmed verified twitter creators can be added to auto contribution list and the attention % displays on the panel as expected
- Confirmed unverified twitter creators can be added to auto contribution list and the attention % displays on the panel as expected
Verified Example (custom image) | Verified Example (added to AC list) | Verified Example (no custom image) | Unverified Example (uses default twitter image) | Unverified Example (added to AC list) | AC list |
---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Additionally, did some navigation checks to ensure panel showed correct creator info:
Visited several twitter pages in succession and then used back/forward browser buttons to navigate through the visited pages. Confirmed the panel showed the expected twitter user info each time.
Repeated above test while logged in to twitter. Confirmed the panel showed the expected twitter user info each time.
Visited several twitter (and non-twitter) pages in various tabs/windows. Visit these twitter (and non-twitter) tabs/windows in various orders, opening the panel to confirm the expected creator info (twitter, non-twitter, verified, non-verified) is shown as expected each time.
Repeated above test while logged in to twitter. Confirmed the panel showed the expected creator info (twitter, non-twitter, verified, non-verified) is shown as expected each time.
In our extension API adapter, the
isGreaselionURL
function seems to be missing an entry fortwitter.com
. Based on inspection of the code it seems that this doesn't cause an error per se (just some unnecessary work) but we should add it in there for consistency.The text was updated successfully, but these errors were encountered: