Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add twitter.com to recognized Greaselion URLs #13689

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Jun 8, 2022

Resolves brave/brave-browser#23332

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Just a simple verification that Twitter sites continue to work as expected in the Rewards panel.

@emerick emerick requested a review from a team as a code owner June 8, 2022 15:30
@emerick emerick self-assigned this Jun 8, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jun 8, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@emerick
Copy link
Contributor Author

emerick commented Jun 8, 2022

CI passed; ready to merge.

@emerick emerick merged commit 5cd48a0 into master Jun 8, 2022
@emerick emerick deleted the emerick-twitter-greaselion-url branch June 8, 2022 21:26
@emerick emerick added this to the 1.41.x - Nightly milestone Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recognize twitter.com as a Greaselion url
3 participants