Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expire Brave Ads catalog after last_updated + ping #23581

Closed
tmancey opened this issue Jun 21, 2022 · 2 comments
Closed

Expire Brave Ads catalog after last_updated + ping #23581

tmancey opened this issue Jun 21, 2022 · 2 comments
Assignees
@tmancey
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. enhancement feature/ads needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude

Comments

@tmancey
Copy link
Contributor

tmancey commented Jun 21, 2022

Expire Brave Ads catalog after last_updated + ping. After the catalog has expired an update must occur before ads are served.
@tmancey tmancey self-assigned this Jun 21, 2022
@tmancey tmancey mentioned this issue Jun 21, 2022
Closed
25 tasks
@tmancey tmancey added blocked needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Jun 14, 2023
@tmancey
Copy link
Contributor Author

tmancey commented Jun 14, 2023

Blocking as discussing with wider team on whether this is needed or not

@tmancey tmancey added closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. and removed blocked labels Jun 14, 2023
@tmancey
Copy link
Contributor Author

tmancey commented Jun 14, 2023

Closing as wont fix, because campaigns may still be active and should be shown.

@tmancey tmancey closed this as completed Jun 14, 2023
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. enhancement feature/ads needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expire Brave Ads catalog after last_updated + ping [DO NOT MERGE] brave/brave-core
1 participant
@tmancey