Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expire Brave Ads catalog after last_updated + ping [DO NOT MERGE] #13889

Closed
wants to merge 1 commit into from
Closed

Expire Brave Ads catalog after last_updated + ping [DO NOT MERGE] #13889

wants to merge 1 commit into from

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jun 21, 2022

Resolves brave/brave-browser#23581

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#23581

@tmancey tmancey requested a review from a team as a code owner June 21, 2022 21:17
@tmancey tmancey self-assigned this Jun 21, 2022
@tmancey tmancey force-pushed the issues/23581 branch 2 times, most recently from ac184c8 to 6f370ce Compare June 21, 2022 21:42
@tmancey
Copy link
Collaborator Author

tmancey commented Jun 21, 2022

@evq this would revert brave/brave-browser#20843, and the catalog would need to be refreshed after current time + ping with a new id server side for users to continue to see ads

moritzhaller
moritzhaller previously approved these changes Jun 22, 2022
View reviewed changes
@tmancey tmancey changed the title Expire Brave Ads catalog after last_updated + ping Expire Brave Ads catalog after last_updated + ping [DO NOT MERGE] Jun 22, 2022
@tmancey tmancey force-pushed the issues/23581 branch 2 times, most recently from cc50ad3 to e095608 Compare June 27, 2022 17:37
@tmancey tmancey force-pushed the issues/23581 branch 3 times, most recently from bc2acf9 to d52a18c Compare July 5, 2022 17:41
@tmancey tmancey force-pushed the issues/23581 branch 6 times, most recently from 99de0a2 to 7c698c3 Compare July 14, 2022 18:57
@tmancey tmancey force-pushed the issues/23581 branch 3 times, most recently from b8d92d1 to 0d90afb Compare July 25, 2022 17:02
@tmancey tmancey force-pushed the issues/23581 branch 4 times, most recently from 2b437e3 to b145dec Compare August 2, 2022 14:58
@tmancey tmancey force-pushed the issues/23581 branch 3 times, most recently from 3b2707a to b91ca8e Compare August 4, 2022 18:55
@tmancey tmancey force-pushed the issues/23581 branch 3 times, most recently from 63615d8 to d688c06 Compare January 9, 2023 16:34
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: dc65736aa227130fbe4025cd6bf786f0c057c91e
reason: unsigned
Please follow the handbook to configure commit signing
cc: @tmancey

@tmancey tmancey added the CI/skip Do not run CI builds (except noplatform) label Jan 19, 2023
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 97b8dee
reason: unsigned
Please follow the handbook to configure commit signing
cc: @tmancey

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

⚠️ PR head is an unsigned commit
commit: 1b14ec4
reason: unsigned
Please follow the handbook to configure commit signing
cc: @tmancey

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

⚠️ PR head is an unsigned commit
commit: 0d1e127
reason: unsigned
Please follow the handbook to configure commit signing
cc: @tmancey

@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 49f8fd5
reason: unsigned
Please follow the handbook to configure commit signing
cc: @tmancey

@tmancey tmancey force-pushed the issues/23581 branch 2 times, most recently from 73cb282 to 51370ff Compare March 5, 2023 14:29
@tmancey tmancey force-pushed the issues/23581 branch 2 times, most recently from b672d8e to 4ac9467 Compare March 12, 2023 22:19
@tmancey tmancey force-pushed the issues/23581 branch 4 times, most recently from 67c20aa to 4d8fa5e Compare March 23, 2023 11:41
@tmancey tmancey force-pushed the issues/23581 branch 4 times, most recently from 102bcd8 to a853aac Compare March 28, 2023 09:16
@tmancey tmancey closed this Jun 14, 2023
@tmancey tmancey deleted the issues/23581 branch June 14, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moritzhaller moritzhaller moritzhaller left review comments

Assignees

@tmancey tmancey

Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expire Brave Ads catalog after last_updated + ping
2 participants
@tmancey @moritzhaller