Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark bar hover backdrop different for site or folder #23667

Closed
rubenpoppe opened this issue Jun 24, 2022 · 5 comments · Fixed by brave/brave-core#14003
Closed

Bookmark bar hover backdrop different for site or folder #23667

rubenpoppe opened this issue Jun 24, 2022 · 5 comments · Fixed by brave/brave-core#14003
Assignees
Labels
bug design A design change, especially one which needs input from the design team OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include

Comments

@rubenpoppe
Copy link

rubenpoppe commented Jun 24, 2022

Description

The hover backdrop on the bookmark bar differs between a site or a folder. Not sure if intended.

Steps to Reproduce

  1. Add item to the bookmark bar
  2. Create folder on the bookmark bar

Actual result:

image

Expected result:

176397339-d5cba951-026a-4459-947c-52ce14d5cb56

Reproduces how often:

Every time

Brave version (brave://version info)

Brave: 1.40.105 Chromium: 103.0.5060.53 (Official Build) (64-bit)
Revision: a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS: Windows 11 Version 22H2 (Build 22621.105)

Version/Channel Information:

Tested on current release

@rebron rebron added bug design A design change, especially one which needs input from the design team labels Jun 24, 2022
@rebron
Copy link
Collaborator

rebron commented Jun 24, 2022

cc: @emerick Chromium 103 related issue?

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include labels Jun 24, 2022
@rebron
Copy link
Collaborator

rebron commented Jun 24, 2022

Bookmark folder background hover should match background hover for an individual link, more squared/soft round versus the Chrome style round.
cc: @aguscruiz

@aguscruiz
Copy link

Agreed, we should keep the original style, at least for now, so it's consistent

@kjozwiak
Copy link
Member

kjozwiak commented Jul 6, 2022

The above will require 1.41.94 or higher for 1.41.x verification 👍

@LaurenWags
Copy link
Member

LaurenWags commented Jul 7, 2022

Verified with

Brave | 1.41.94 Chromium: 103.0.5060.114 (Official Build) (x86_64)
-- | --
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | macOS Version 12.4 (Build 21F79)

Verified STR from #23667 (comment) and brave/brave-core#14003 (comment).

Confirmed expected hover shape for bookmarks and folders on the bookmark bar as compared to 1.40.x.

1.40.113 1.41.94
1 3
2 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug design A design change, especially one which needs input from the design team OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants