Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guest windows brave://settings page is blank #24242

Closed
GeetaSarvadnya opened this issue Jul 25, 2022 · 7 comments · Fixed by brave/brave-core#14342
Closed

Guest windows brave://settings page is blank #24242

GeetaSarvadnya opened this issue Jul 25, 2022 · 7 comments · Fixed by brave/brave-core#14342

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 25, 2022

Description

Found while testing #23092
Guest windows brave://settings page is blank

Steps to Reproduce

  1. Clean profile 1.43.43
  2. Select Open Guest window from the hamburger menu
  3. Open brave://settings/ page
  4. Page is empty

Actual result:

image

Expected result:

Page should not be empty

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.43.43 Chromium: 104.0.5112.57 (Official Build) nightly (64-bit)
Revision 212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS Windows 10 Version 21H2 (Build 19044.1826)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @rebron @mkarolin

@LaurenWags
Copy link
Member

@GeetaSarvadnya reproduced with 1.42.73 per https://bravesoftware.slack.com/archives/C7VLGSR55/p1658746352488389?thread_ts=1658511238.357929&cid=C7VLGSR55.

I could not reproduce with 1.42.66 but did reproduce with 1.42.74.

@LaurenWags
Copy link
Member

LaurenWags commented Jul 25, 2022

Per https://bravesoftware.slack.com/archives/C7VLGSR55/p1658752358754959?thread_ts=1658511238.357929&cid=C7VLGSR55, this was last working in 1.42.69. Broke with 1.42.70. Only item uplifted between these two versions per https://github.com/brave/brave-core/commits/1.42.x was brave/brave-core#14208.

cc @spylogsster

1.42.69 1.42.70
69 70

@rebron
Copy link
Collaborator

rebron commented Jul 26, 2022

@kjozwiak To revert brave/brave-core#14208

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jul 26, 2022
@bsclifton bsclifton added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jul 27, 2022
@bsclifton
Copy link
Member

Bumped up to P2 as we will want to uplift to 1.43

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jul 27, 2022

Please note brave://settings/help page is also empty in Guest window

image

@kjozwiak
Copy link
Member

The above requires 1.43.52 or higher for 1.43.x verification.

@MadhaviSeelam
Copy link

Verification Passed using

Brave | 1.43.54 Chromium: 104.0.5112.69 (Official Build) beta (64-bit)
-- | --
Revision | 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS | Windows 11 Version 21H2 (Build 22000.795)

Verified using original steps #24242 (comment)

Confirmed opening brave:/settings and brave://settings/help loaded correct pages for Guest window

brave://settings brave://settings/help
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants