Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing from Chromium browsers will import (and enable) disabled extensions #24250

Closed
bsclifton opened this issue Jul 25, 2022 · 2 comments · Fixed by brave/brave-core#14493

Comments

@bsclifton
Copy link
Member

bsclifton commented Jul 25, 2022

Description

Importing extensions from Chromium browsers will import and enable disabled extensions

Steps to Reproduce

  1. Have an install of Chrome, Chromium, Microsoft Edge, etc
  2. Install an extension from Chrome Web Store
  3. Visit chrome://extensions and disable that extension
  4. Close the browser
  5. Open Brave (new profile)
  6. Import from the browser you used in Step 1

Actual result:

The disabled extension will be imported and enabled

Expected result:

The disabled extension should NOT be imported

Reproduces how often:

100%

@kjozwiak
Copy link
Member

The above requires 1.43.71 for higher for 1.43.x verification 👍

@MadhaviSeelam
Copy link

MadhaviSeelam commented Aug 18, 2022

Verification Passed using

Brave | 1.43.73 Chromium: 104.0.5112.81 (Official Build) beta (64-bit)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | Windows 11 Version 21H2 (Build 22000.856)

Verified STR from #24250 (comment)

  1. installed Chrome
  2. installed LassPass:Free Password Manager extension from Chrome Web Store
  3. visited chrome://extensions and disable that extension
  4. closed chrome browser
  5. installed 1.43.73
  6. launched Brave
  7. clicked on Import bookmarks now... in the bookmarks bar

Confirmed Extensions option is not available if it's disabled in Import bookmarks and settings modal

Step 2 Step 3 Step6
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants