Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Remove unused rewards code #24385

Closed
deeppandya opened this issue Aug 2, 2022 · 2 comments · Fixed by brave/brave-core#14434
Closed

[Android] Remove unused rewards code #24385

deeppandya opened this issue Aug 2, 2022 · 2 comments · Fixed by brave/brave-core#14434
Assignees
@deeppandya
Labels
dev-concern feature/rewards OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude
Milestone
1.44.x - Release

Comments

@deeppandya
Copy link
Contributor

This issue is to refactor previous rewards related changes. We should remove all unused references to previous rewards implementation.
@deeppandya deeppandya added QA/No release-notes/exclude OS/Android Fixes related to Android browser functionality labels Aug 2, 2022
@deeppandya deeppandya self-assigned this Aug 2, 2022
@deeppandya deeppandya mentioned this issue Aug 2, 2022
Merged
25 tasks
@Miyayes Miyayes changed the title Remove unused rewards code [Android] Remove unused rewards code Aug 9, 2022
@deeppandya deeppandya added QA/Yes and removed QA/No labels Aug 11, 2022
@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Aug 12, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 20, 2022 •
edited
Loading

Will be tested as part of the C106 regression checks as well as checking while running through the full manual pass when C106 gets uplifted into 1.44.x. But QA will complete spot check.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 22, 2022 •
edited
Loading

Verification PASSED on Vivo x70 pro with android version 12 running Bravemonoarmx64.apk_1.44.95

  • Verified the test plan from Remove unused rewards panel code brave-core#14434
  • Verified the panel controls for all the custodians
  • Verified the panel in publishers page, rewards settings page and BR panel and ensured that panel feature is working as expected
  • Verifie that the click on Add fund in the BR panel openes up the uphold sign in page after provinding the credentials the uphold Transact screen is displayed to trasfer the funds
  • Verified that click on Withdraw funds in the BR panel openes up the uphold sign in page after provinding the credentials the uphold Transact screen is displayed to trasfer the funds
  • Verified that the AC, Monthly contribution and one-time tip, wallet balance with BAT and USD conversation are displayed as expected
  • Verified that click on Summary in the BR panel opens up the rewards summary in the panel
  • Additional testing is covered in Remove support for legacy anonymous Uphold cards #24464 (comment)
Example Example Example Example Example
Screenshot_20221023_151035 Screenshot_20221023_152625 Screenshot_20221023_151135 Screenshot_20221023_151152 Screenshot_20221023_151611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
dev-concern feature/rewards OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.44.x - Release
Development

Successfully merging a pull request may close this issue.

Remove unused rewards panel code brave/brave-core
5 participants
@deeppandya @Miyayes @Uni-verse @GeetaSarvadnya @brave-builds