Remove support for legacy anonymous Uphold cards

[szilardszaloki]

No description provided.

[LaurenWags]

Labelling as QA/Blocked for now, just until @brave/qa-team reviews with @szilardszaloki and @Miyayes 👍🏻

[LaurenWags]

Discussed the following with @szilardszaloki and @GeetaSarvadnya re: test plan:

Desktop

Using description from PR as a guide:

Backup/Restore Modal:

• confirm the anon user funded specific-variant for backup tab of backup/restore modal does not show on upgraded or clean profiles (pictured on PR)
• confirm the regular backup tab of backup/restore modal does display as expected

Backup Notification:

• skip as this has been dead code for some time (will not be able to trigger)

P3A:

• confirm 1.43.x does have these questions
• using a new profile, confirm 1.44.x does not have these questions
• not necessary to test upgraded profiles for P3A

Prefs:

• skip, unable to test

Anonymous wallet/user funds processor references in the contribution engine:

• check 1 time tips, monthly tips, and AC all contribute/work as expected for anon vBAT funded and applicable custodians (ex. bF does not have AC)

POST /v1/orders/{order_id}/transactions/anonymousCard endpoint implementation

• skip, unable to test

GET /v3/wallet/uphold/{payment_id} endpoint implementation

• check tipping, covered above

Balance fetch

• confirm balances from anon vBAT funded and custodians are displayed appropriately, can be checked as part of Anonymous wallet/user funds processor references in the contribution engine

Uphold linking

• confirm able to link Uphold, can be checked as part of Anonymous wallet/user funds processor references in the contribution engine

Wallet creation

• confirm able to join rewards and get a valid paymentID, can be checked as part of Anonymous wallet/user funds processor references in the contribution engine

Wallet recovery

• confirm unable to restore an old anon, user funded wallet using restore words, can be checked as part of Backup/Restore Modal above

Android

Using description from PR as a guide:

Backup/Restore Modal:

• I don't believe backup/restore is generally available on Android outside of QA Prefs, so for that confirm unable to restore an old anon, user funded rewards wallet using restore words

Backup Notification:

• skip as this has been dead code for some time (will not be able to trigger)

P3A:

• confirm 1.43.x does have these questions
• using a new profile, confirm 1.44.x does not have these questions
• not necessary to test upgraded profiles for P3A

Prefs:

• skip, unable to test

Anonymous wallet/user funds processor references in the contribution engine:

• check 1 time tips, monthly tips, and AC all contribute/work as expected for anon vBAT funded and applicable custodians (ex. bF does not have AC)

POST /v1/orders/{order_id}/transactions/anonymousCard endpoint implementation

• skip, unable to test

GET /v3/wallet/uphold/{payment_id} endpoint implementation

• check tipping, covered above

Balance fetch

• confirm balances from anon vBAT funded and custodians are displayed appropriately, can be checked as part of Anonymous wallet/user funds processor references in the contribution engine

Uphold linking

• confirm able to link Uphold, can be checked as part of Anonymous wallet/user funds processor references in the contribution engine

Wallet creation

• confirm able to join rewards and get a valid paymentID, can be checked as part of Anonymous wallet/user funds processor references in the contribution engine

Wallet recovery

• confirm unable to restore an old anon, user funded wallet using restore words, can be checked as part of Backup/Restore Modal above

iOS

Since Rewards is scaled back on iOS, using a clean profile confirm able to join Rewards/opt-in to viewing ads. Use the QA page to confirm paymentID is created as expected. Confirm able to view ads and be rewarded for them.

On upgrade profile, confirm opt-in status for Rewards/Ads (check both opted-in and not opted-in). Confirm if opt-ed in, your paymentID is the same before and after upgrade. Confirm you can still view ads after upgrade.

[LaurenWags]

Verified with

Brave | 1.44.77 Chromium: 105.0.5195.102 (Official Build) beta (x86_64)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | macOS Version 12.5.1 (Build 21G83)

Per Desktop section of #24464 (comment):

Skipped the following:

• Backup Notification
• Prefs
• POST /v1/orders/{order_id}/transactions/anonymousCard endpoint implementation

Backup/Restore Modal - PASSED

Upgraded Profile:

• Confirmed the anon user funded specific-variant for backup tab of backup/restore modal does not show on upgraded profile
• Confirmed user funded balance displayed in 1.43.x, but does not display in 1.44.x

1.43.x	1.44.x

Clean Profile:

• Confirmed the anon user funded specific-variant for the backup tab of backup/restore modal does not show on a clean profile (unable to restore same wallet used in 1.43.x)
• Confirmed user funded balance does not display in 1.44.x due to not being able to restore the wallet on a clean profile
• Confirmed the regular backup tab of backup/restore modal does display as expected

Example	Example	Example	Example	Example

P3A - PASSED

Confirmed 1.43.x (with restored user-funded, anonymous Rewards backup words), does have the Brave.Rewards.WalletState and Brave.Rewards.WalletBalance.3 P3A questions.
Using a new profile, confirmed 1.44.x does not have the Brave.Rewards.WalletState and Brave.Rewards.WalletBalance.3 P3A questions.

1.43.x	1.44.x

Brave | 1.44.79 Chromium: 105.0.5195.102 (Official Build) beta (x86_64)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | macOS Version 12.5.1 (Build 21G83)

Anonymous wallet/user funds processor references in the contribution engine - PASSED

Anon (vBAT) Rewards - PASSED

Confirmed 1 time tips work as expected (confirmed able to tip connected and KYC'd publishers, non verified creator tips went to Pending list).

Example	Example	Example	Example	Example

Confirmed monthly tips work as expected.

Example	Example	Example	Example

Confirmed auto contribution works as expected.

Example	Example	Example	Example

Gemini - PASSED

Confirmed 1 time tips work as expected (confirmed able to tip Gemini KYC'd publishers, non verified creator and different custodian KYC'd tips went to Pending list).

Example	Example	Example	Example	Example

Confirmed monthly tips work as expected.

Example	Example	Example	Example

Confirmed auto contribution works as expected.

Example	Example	Example	Example

Uphold - PASSED

Confirmed 1 time tips work as expected (confirmed able to tip Uphold KYC'd publishers, non verified creator and different custodian KYC'd tips went to Pending list).

Example	Example	Example	Example	Example

Confirmed monthly tips work as expected.

Example	Example	Example	Example

Confirmed auto contribution works as expected.

Example	Example	Example	Example

bitFlyer - PASSED

Confirmed 1 time tips work as expected (confirmed able to tip bitFlyer KYC'd publishers, non verified creator and different custodian KYC'd tips went to Pending list).

Example	Example	Example	Example	Example

Confirmed monthly tips work as expected.

Example	Example	Example	Example

Confirmed no mention of auto contribution on brave://rewards page or panel.

Example	Example

Balance fetch - PASSED

Confirmed balances from anon vBAT funded and all 3 custodians (Uphold, Gemini, bitFlyer) are displayed appropriately.
Verified as part of the Anonymous wallet/user funds processor references in the contribution engine, see that section for screenshots.

Uphold linking - PASSED

Confirmed able to link KYC'd Uphold account to Rewards.
Verified as part of the Anonymous wallet/user funds processor references in the contribution engine, see that section for screenshots.
Note, also checked VERIFIED and DISCONNECTED_VERIFIED statuses as part of a different issue, see #24112 (comment) for details.
Encountered issue with brave://rewards page not showing DISCONNECTED_VERIFIED status when the panel does - logged as #25311. Not sure it's due to the change covered by this issue/PR, but it can be encountered during this testing.

Wallet creation - PASSED

Confirmed able to join rewards and get a valid paymentID.
Verified as part of the Anonymous wallet/user funds processor references in the contribution engine, see that section for screenshots.

Wallet recovery - PASSED

Confirmed unable to restore an old anon, user funded wallet using restore words.
Verified as part of the Backup/Restore Modal, see that section for screenshots.

[Uni-verse]

@kylehickinson Please review and provide some feedback on how we should proceed for iOS. Whether i should create related issue on iOS or can be handled another way. Thanks.

#24464 (comment)

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.44.93 Chromium: 105.0.5195.136 (Official Build) beta (64-bit)
-- | --
Revision | 872774b783d0e674186a3adcd2f92e7aa22a219c-refs/branch-heads/5195_124@{#4}
OS | Windows 10 Version 21H2 (Build 19044.2006)

• Verified the test plan from Remove support for legacy anonymous Uphold cards #24464 (comment)

Backup/Restore Modal - PASSED

Upgraded Profile:

• Confirmed the anon user funded specific-variant for backup tab of backup/restore modal does not show on upgraded profile
• Confirmed user funded balance displayed in 1.43.x, but does not display in 1.44.x

1.43.x	1.44.x

1.43.x	1.44.x

1.43.x	1.44.x

1.43.x	1.44.x

1.43.x	1.44.x

Clean Profile:

• Confirmed the anon user funded specific-variant for the backup tab of backup/restore modal does not show on a clean profile (unable to restore same wallet used in 1.43.x)
• Confirmed user funded balance does not display in 1.44.x due to not being able to restore the wallet on a clean profile
• Confirmed the regular backup tab of backup/restore modal does display as expected

Example	Example	Example	Example	Example

P3A - PASSED

Confirmed 1.43.x (with restored user-funded, anonymous Rewards backup words), does have the Brave.Rewards.WalletState and Brave.Rewards.WalletBalance.3 P3A questions.
Using a new profile, confirmed 1.44.x does not have the Brave.Rewards.WalletState and Brave.Rewards.WalletBalance.3 P3A questions.

1.43.x	1.44.x

Anonymous wallet/user funds processor references in the contribution engine - PASSED

Anon (vBAT) Rewards -PASSED

Confirmed 1 time tips work as expected (confirmed able to tip connected and KYC'd publishers, non verified creator tips went to Pending list).

Example	Example	Example	Example	Example

Confirmed monthly tips work as expected.

Example	Example	Example	Example

Confirmed auto contribution works as expected.

Example	Example	Example	Example

Gemini - PASSED

Confirmed 1 time tips work as expected (confirmed able to tip Gemini KYC'd publishers, non verified creator and different custodian KYC'd tips went to Pending list).

Example	Example	Example	Example	Example

Confirmed monthly tips work as expected.

Example	Example	Example	Example

Confirmed auto contribution works as expected.

Example	Example	Example	Example

Uphold - PASSED

Confirmed 1 time tips work as expected (confirmed able to tip Uphold KYC'd publishers, non verified creator and different custodian KYC'd tips went to Pending list).

Example	Example	Example	Example	Example

Confirmed monthly tips work as expected.

Example	Example	Example	Example

Confirmed auto contribution works as expected.

Example	Example	Example	Example

bitFlyer - SKIPPED

• Unable to test as we don't have bF verified pubs

Balance fetch - PASSED

Confirmed balances from anon vBAT funded and all 3 custodians (Uphold, Gemini, bitFlyer) are displayed appropriately.
Verified as part of the Anonymous wallet/user funds processor references in the contribution engine, see that section for screenshots.

Uphold linking - PASSED

Confirmed able to link KYC'd Uphold account to Rewards.
Verified as part of the Anonymous wallet/user funds processor references in the contribution engine, see that section for screenshots.

Wallet creation - PASSED

Confirmed able to join rewards and get a valid paymentID.
Verified as part of the Anonymous wallet/user funds processor references in the contribution engine, see that section for screenshots.

Wallet recovery - PASSED

Confirmed unable to restore an old anon, user funded wallet using restore words.
Verified as part of the Backup/Restore Modal, see that section for screenshots.

[GeetaSarvadnya]

Verification PASSED on Vivo x70 pro with android version 12 running Bravemonoarm64.apk_1.44.95

• Verified the test plan from Remove support for legacy anonymous Uphold cards #24464 (comment)

Android section from #24464 (comment)

P3A - PASSED

Confirmed 1.43.x does have the Brave.Rewards.WalletState and Brave.Rewards.WalletBalance.3 P3A questions.
Using a new profile, confirmed 1.44.x does not have the Brave.Rewards.WalletState and Brave.Rewards.WalletBalance.3 P3A questions.

1.43.x	1.44.x

Anonymous wallet/user funds processor references in the contribution engine - PASSED

Anon (vBAT) Rewards -PASSED

Confirmed 1 time tips work as expected (confirmed able to tip connected and KYC'd publishers, non verified creator tips went to Pending list).

Example	Example	Example	Example	Example

Confirmed monthly tips work as expected.

Example	Example	Example

Confirmed auto contribution works as expected.

Example	Example	Example

Gemini - PASSED

Confirmed 1 time tips work as expected (confirmed able to tip Gemini KYC'd publishers, non verified creator and different custodian KYC'd tips went to Pending list).

Example	Example	Example	Example	Example

Confirmed monthly tips work as expected.

Example	Example	Example

Confirmed auto contribution works as expected.

Example	Example	Example	Example

Uphold - PASSED

Confirmed 1 time tips work as expected (confirmed able to tip Uphold KYC'd publishers, non verified creator and different custodian KYC'd tips went to Pending list).

Example	Example	Example	Example	Example

Confirmed monthly tips work as expected.

Example	Example	Example

Confirmed auto contribution works as expected.

Example	Example	Example

Ensured that the GET /v3/wallet/uphold/{payment_id} endpoint is implemented

[ REQUEST ]
    > URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/7c07511d-4f8d-41ba-9355-67a6901d320b/claim
    > Method: POST
    > Content: {"signedLinkingRequest":"eyJib2R5Ijp7ImRlbm9taW5hdGlvbiI6eyJhbW91bnQiOiIwIiwiY3VycmVuY3kiOiJCQVQifSwiZGVzdGluYXRpb24iOiI0ZjE1Nzg2OC1lMjQzLTRlYWItYmJlYS1lMTAzMThhM2I5NzEifSwiaGVhZGVycyI6eyJkaWdlc3QiOiJTSEEtMjU2PThWbmdyanBDT3crbS9MSC9DNXMrL3hCMzRYZXFHeDNWTHl3aUJXM0pNOXc9Iiwic2lnbmF0dXJlIjoia2V5SWQ9XCJwcmltYXJ5XCIsYWxnb3JpdGhtPVwiZWQyNTUxOVwiLGhlYWRlcnM9XCJkaWdlc3RcIixzaWduYXR1cmU9XCJQeStpN3FwcU1PZW45NDdJcyttc1RzaThtWDhUdEl0VVkvUlpIK2JFcm9nUzNWYksxVGpUN0I2YUx0Q212SDViU2h6YU1jZUV6c3ZnUURrZFJTa1ZEUT09XCIifSwib2N0ZXRzIjoie1wiZGVub21pbmF0aW9uXCI6e1wiYW1vdW50XCI6XCIwXCIsXCJjdXJyZW5jeVwiOlwiQkFUXCJ9LFwiZGVzdGluYXRpb25cIjpcIjRmMTU3ODY4LWUyNDMtNGVhYi1iYmVhLWUxMDMxOGEzYjk3MVwifSJ9"}
    > Content Type: application/json; charset=utf-8
2022-09-27 20:29:43.883 9301-9301/? V/chromium: [VERBOSE6:logging_util.cc(137)] 
    [ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/7c07511d-4f8d-41ba-9355-67a6901d320b/claim
    > Result: Success
    > HTTP Code: 200
    > Body: null
2022-09-27 20:29:43.910 9301-9301/? V/chromium: [VERBOSE5:ledger_impl.cc(117)] 

bitFlyer - SKIPPED

• Unable to test as we don't have bF verified pubs

Balance fetch - PASSED

Confirmed balances from anon vBAT funded and all 3 custodians (Uphold, Gemini, bitFlyer) are displayed appropriately.
Verified as part of the Anonymous wallet/user funds processor references in the contribution engine, see that section for screenshots.

Uphold linking - PASSED

Confirmed able to link KYC'd Uphold account to Rewards.
Verified as part of the Anonymous wallet/user funds processor references in the contribution engine, see that section for screenshots.

Wallet creation - PASSED

Confirmed able to join rewards and get a valid paymentID.
Verified as part of the Anonymous wallet/user funds processor references in the contribution engine, see that section for screenshots.