Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AdsImpl methods from std::function to base::OnceCallback #24661

Closed
aseren opened this issue Aug 15, 2022 · 1 comment · Fixed by brave/brave-core#15748
Closed

Refactor AdsImpl methods from std::function to base::OnceCallback #24661

aseren opened this issue Aug 15, 2022 · 1 comment · Fixed by brave/brave-core#15748
Assignees
@aseren
Labels
dev-concern feature/ads OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.47.x - Release

Comments

@aseren
Copy link

aseren commented Aug 15, 2022

No description provided.

@aseren aseren self-assigned this Aug 15, 2022
@aseren aseren mentioned this issue Aug 19, 2022
Closed
@tmancey tmancey added the priority/P4 Planned work. We expect to get to it "soon". label Aug 24, 2022
@tmancey tmancey added this to the 1.44.x - Beta milestone Aug 24, 2022
@tmancey tmancey removed this from the 1.44.x - Beta milestone Sep 16, 2022
@aseren aseren mentioned this issue Nov 1, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Nov 4, 2022
@btlechowski
Copy link

Verification passed on

Brave 1.47.101 Chromium: 108.0.5359.48 (Official Build) beta (64-bit)
Revision 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#15748

Checked that brave rewards page shows correct statement information:

previous month earnings, this month earnings, next payment date, number of ads received this month

image

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
dev-concern feature/ads OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

Refactor some BatAds methods to base::OnceCallback brave/brave-core
4 participants
@tmancey @btlechowski @brave-builds @aseren