Refactor ads::ResultCallback to base::OnceCallback

[aseren]

No description provided.

[aseren]

QA could be done together with this issue: #20940

[btlechowski]

Verification passed on

Brave	1.44.75 Chromium: 105.0.5195.102 (Official Build) beta (64-bit)
Revision	4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#14698

Verified Bat Ads resources are downloaded and loaded

[3836:3836:0907/144331.962012:VERBOSE1:resource_manager.cc(49)] Resource id iblokdlgekdjophgeonmanpnjihcjkjj updated
[3836:3836:0907/144331.962100:VERBOSE1:ads_service_impl.cc(1630)] Loading file resource from /home/bartlomiej/.config/BraveSoftware/Brave-Browser-Beta/iblokdlgekdjophgeonmanpnjihcjkjj/1.0.64/dnryisldmaqljgwaxeqbuuhuvrbboqlf for component id nnqccijfhvzwyrxpxwjrpmynaiazctqb
[3836:3836:0907/144331.962345:VERBOSE1:ads_service_impl.cc(1630)] Loading file resource from /home/bartlomiej/.config/BraveSoftware/Brave-Browser-Beta/iblokdlgekdjophgeonmanpnjihcjkjj/1.0.64/kkjipiepeooghlclkedllogndmohhnhi for component id bejenkminijgplakmkmcgkhjjnkelbld
[3836:3836:0907/144331.974794:VERBOSE1:anti_targeting_resource.cc(52)] Failed to load mkdhnfmjhklfnamlheoliekgeohamoig anti-targeting resource
[3836:3836:0907/144332.014836:VERBOSE1:conversions_resource.cc(46)] Successfully loaded nnqccijfhvzwyrxpxwjrpmynaiazctqb conversions resource
[3836:3836:0907/144332.034010:VERBOSE1:conversions_resource.cc(57)] Parsed conversions resource version 1
[3836:3836:0907/144332.034218:VERBOSE1:conversions_resource.cc(62)] Successfully initialized nnqccijfhvzwyrxpxwjrpmynaiazctqb conversions resource
[3836:3836:0907/144332.109399:VERBOSE1:purchase_intent_resource.cc(48)] Successfully loaded bejenkminijgplakmkmcgkhjjnkelbld purchase intent resource
[3836:3836:0907/144332.123904:VERBOSE1:purchase_intent_resource.cc(61)] Parsed purchase intent resource version 1
[3836:3836:0907/144332.124150:VERBOSE1:purchase_intent_resource.cc(66)] Successfully initialized bejenkminijgplakmkmcgkhjjnkelbld purchase intent resource

Verified Browser is able to fetch issuers, catalog, ads subdivision

Issuers

[3836:3836:0907/144332.190165:VERBOSE6:issuers.cc(69)] URL Response:
  URL: https://static.ads.bravesoftware.com/v1/issuers/
  Response Status Code: 200
  Response: {"ping":7200000,"issuers":[{"name":"payments","publicKeys":[{"publicKey":"fA3yRQr9501W3CJu2liws20AWntkQIZ/MJxActVoBwE=","associatedValue":"0.25"},{"publicKey":"MuMsRFlpqwkHXtvNlBZlPKQaOAKKURyaT73J3xHI2h8=","associatedValue":"0.20"},{"publicKey":"hosmrajSDxihP3e06QmerHMw1Eebavki1j0kTuhcXCw=","associatedValue":"0.05"},{"publicKey":"Uil16vc0Vw/x74Bqh2gjnUuTzsBxToaDjpuWyvQiQwM=","associatedValue":"0.10"},{"publicKey":"TiwNyrFsGAdZubFTleWxAmCMl+79Z8g6o+rCY+qfQjo=","associatedValue":"0.15"},{"publicKey":"ujkm+UD5nSQlx+poc+KXA+gPgohjnevLaq2+zlhhCzg=","associatedValue":"0.25"},{"publicKey":"cGfa0e4wG/zXmc89eP0n19FwDLgRddezE8VF+LLcSX0=","associatedValue":"0.20"},{"publicKey":"nli/ERzfnbgMPLB6FCUvstCVnvlmBX4WMN2qYcdhPEk=","associatedValue":"0.15"},{"publicKey":"/ErFCyyTs6tQ+VCve8GsGcNZ4dZhYKIBisLZIbR+kR4=","associatedValue":"0.01"},{"publicKey":"hPG3j7g7Vb6y635dinW8AVX5Izkh22hXfLXzPpnRRw8=","associatedValue":"0"},{"publicKey":"4G0t4s/hogWBj50kVo1oFG9Q9K+Ou8n5/rYMN2s7hHI=","associatedValue":"0.3"},{"publicKey":"NFZWj/+s0mQapPEibEW8iYZVOBm/0s2OfIZDTtbxVD8=","associatedValue":"0.10"},{"publicKey":"RLhTcDwr1lhDLr3z3nzkOff39JdDqpppEVrPb6XlOAo=","associatedValue":"0.025"},{"publicKey":"LJkEkXmRRBdPcxHr5qMxrp7t557STPPPvndqAWtiTzU=","associatedValue":"0.025"},{"publicKey":"+r7tAB4bf8+9fSq8Aatg+0MX/MF6XvtTuSTqFy+hQ3k=","associatedValue":"0.05"},{"publicKey":"lKWsOMznMAJa17QjSfjB/RddW2j77V4QFiQvqdpVIEg=","associatedValue":"0"},{"publicKey":"OFS8IPQnVjzq6dmOx95ru7QF8iUGePDWM0A3irk+zW8=","associatedValue":"0.01"},{"publicKey":"1uPj8jU4esljlsKeliikGzKX++wyeGEfcxKXYaNmBkA=","associatedValue":"0.3"}]},{"name":"confirmations","publicKeys":[{"publicKey":"tE/wUVkQ/F+hg6lmQvrmU0AqppwmcuH6UBvEkC3fqVc=","associatedValue":""},{"publicKey":"mp/79e6Zamgx3w2NwPzfV9WJncGY42pxR0DjT/RagGI=","associatedValue":""},{"publicKey":"VNICQ9eiXYoo+PkuqZuRoPPsUoKxtxPLd2dSipyMNA0=","associatedValue":""}]}]}
[3836:3836:0907/144332.337259:VERBOSE1:account.cc(302)] Updated issuers

catalog

[3836:3836:0907/144332.792613:VERBOSE1:catalog.cc(87)] OnCatalog
[3836:3836:0907/144332.811016:VERBOSE1:catalog.cc(105)] Successfully fetched catalog

subdivision

[3836:3836:0907/144331.926326:VERBOSE1:subdivision_targeting.cc(202)] OnFetchSubdivisionTargeting
[3836:3836:0907/144331.926880:VERBOSE6:subdivision_targeting.cc(204)] URL Response:
  URL: https://geo.ads.bravesoftware.com/v1/getstate
  Response Status Code: 200
  Response: {"country":"PL","region":"02"}

Verified Notification ads can be served. There are viewed, clicked, conversion events

view

[8712:8712:0907/160159.456023:VERBOSE3:notification_ad_event_viewed.cc(23)] Viewed notification ad with placement id 20c46bea-50cd-485c-a631-1e01a6bc75df and creative instance id 4cda5cb7-c4f8-4cbc-8898-58de12ece304
[8712:8712:0907/160159.514077:VERBOSE6:notification_ad_event_viewed.cc(31)] Successfully logged notification ad viewed event
[8712:8712:0907/160159.523927:VERBOSE3:account.cc(166)] Successfully processed deposit for ad_notification with creative instance id 4cda5cb7-c4f8-4cbc-8898-58de12ece304 and view valued at 0.01

clicked

[8712:8712:0907/160212.015087:VERBOSE1:notification_ad_event_clicked.cc(30)] Successfully logged notification ad clicked event
[8712:8712:0907/160212.021640:VERBOSE3:account.cc(166)] Successfully processed deposit for ad_notification with creative instance id 4cda5cb7-c4f8-4cbc-8898-58de12ece304 and click valued at 0

conversion

[8712:8712:0907/160310.922011:VERBOSE1:conversions.cc(348)] There was a conversion match
[8712:8712:0907/160310.937857:VERBOSE6:conversions.cc(411)] Successfully logged conversion event
[8712:8712:0907/160310.945374:VERBOSE3:conversions.cc(440)] Successfully appended conversion to queue

Verified New tab page ad can be served

[19233:19233:0908/033612.534391:VERBOSE1:eligible_new_tab_page_ads_v1.cc(38)] Get eligible new tab page ads:
[19233:19233:0908/033612.570506:VERBOSE1:eligible_new_tab_page_ads_v1.cc(161)] Get eligible ads for untargeted segment
[19233:19233:0908/033612.603744:VERBOSE2:priority.h(34)] 3 ads with a priority of 1 in bucket 1
[19233:19233:0908/033612.604292:VERBOSE1:new_tab_page_ad.cc(61)] Opportunity arose to serve a new tab page ad
[19233:19233:0908/033612.604418:VERBOSE1:new_tab_page_ad_serving.cc(89)] Found 3 eligible ads
[19233:19233:0908/033612.604508:VERBOSE1:new_tab_page_ad_serving.cc(138)] Served new tab page ad:
  placementId: d92a44be-efe9-452d-bce6-6aaa1a924bac
  creativeInstanceId: 23b3eb43-0fed-40e7-bad6-782f13f83a9d
  creativeSetId: e642fae6-e73d-467f-b8a0-451aa17b791e
  campaignId: 5529c5b0-7f84-459f-ada2-764637a9390e
  advertiserId: 216c5e8c-434d-4c72-a9c5-3a11343dde48
  segment: untargeted
  companyName: Unstoppable Domains
  imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/8591bb82-b24a-4ed8-9b92-b0f8dd0f331f.png
  alt: Unstoppable Domains - Discover the future of the web
  targetUrl: https://unstoppabledomains.mypinata.cloud/ipfs/QmTZ4vvV926DN2HwZpd8djLyovFptqk3Xbct71YwJxt28A
  wallpaper:
    imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/fd68ccc5-5072-414e-b231-40ef7cec6036.jpg
    focalPoint:
      x: 1125
      y: 720
[19233:19233:0908/033612.615040:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id d92a44be-efe9-452d-bce6-6aaa1a924bac and creative instance id 23b3eb43-0fed-40e7-bad6-782f13f83a9d
[19233:19233:0908/033612.624026:VERBOSE6:new_tab_page_ad_event_served.cc(31)] Successfully logged new tab page ad served event

Verified Brave News ad can be served

[10786:10786:0907/162016.981089:VERBOSE1:eligible_inline_content_ads_v1.cc(40)] Get eligible inline content ads:
[10786:10786:0907/162016.983703:VERBOSE1:eligible_inline_content_ads_v1.cc(178)] Get eligible ads for untargeted segment
[10786:10786:0907/162016.987346:VERBOSE2:priority.h(34)] 1 ads with a priority of 1 in bucket 1
[10786:10786:0907/162016.987757:VERBOSE1:eligible_inline_content_ads_v1.cc(202)] 1 eligible ads out of 1 ads for untargeted segment
[10786:10786:0907/162016.988052:VERBOSE1:inline_content_ad.cc(70)] Opportunity arose to serve an inline content ad
[10786:10786:0907/162016.988375:VERBOSE1:inline_content_ad_serving.cc(92)] Found 1 eligible ads
[10786:10786:0907/162016.988668:VERBOSE1:inline_content_ad_serving.cc(132)] Served inline content ad:
  placementId: d670921c-7661-4023-953d-cdf94c740298
  creativeInstanceId: e4958d00-e35c-4134-a408-1fbcf274d5ae
  creativeSetId: 8b848823-c47f-43de-a753-2efa8dea6863
  campaignId: 07de7f05-ab32-4af0-a350-a1bce4427eac
  advertiserId: 93130af3-2def-4ecb-b836-b3772e73b3c9
  segment: untargeted
  title: Staging - Inline Test 1
  description: Fung Brave News Inline Display Ad - mac/linux
  imageUrl: https://pcdn.brave.com/brave-ads/468beb93-2458-5d3e-8d7b-bc1f387d2e9b.webp.pad
  dimensions: 900x750
  ctaText: Work at Brave
  targetUrl: https://brave.com/careers
[10786:10786:0907/162017.005232:VERBOSE3:inline_content_ad_event_served.cc(23)] Served inline content ad with placement id d670921c-7661-4023-953d-cdf94c740298 and creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae
[10786:10786:0907/162017.023753:VERBOSE1:inline_content_ad_event_served.cc(31)] Successfully logged inline content ad served event

Verified User is rewarded for a viewed ad

[10500:10500:0907/161413.505343:VERBOSE1:redeem_unblinded_token.cc(353)] Successfully redeemed unblinded token view confirmation for ad_notification with transaction id 7ceb2a9c-d431-4039-8db4-eb3f77f9c84b and creative instance id 4cda5cb7-c4f8-4cbc-8898-58de12ece304