-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images blocked when device language is set to Japanese #2482
Labels
bug
feature/shields/adblock
Blocking ads & trackers with Shields
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Milestone
Comments
Only thing I would comment on from seeing the issue above is that when I repro'd from desktop, the device language (win10) was English. The browser settings had the language set to Japanese. Might not make much of a difference, but noting in case Chrome, etc. do not display the same issue from English OS + Japanese browser level settings. |
Verification passed on
Verified passed with
Verification passed on
Tested on Win 10 VM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
feature/shields/adblock
Blocking ads & trackers with Shields
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Description
Cross posting issue from https://github.com/brave/browser-ios/issues/1811 which reproduces on Desktop as well
Steps to Reproduce
https://youtu.be/36iHqvPeAiw
https://youtu.be/HvnqFkw8qIw
Actual result:
When device language is set to English
https://youtu.be/36iHqvPeAiw
When device language is set to Japanese
https://youtu.be/HvnqFkw8qIw
Expected result:
Should not block based on device language
Reproduces how often:
Easy
Brave version (brave://version info)
Release build 0.58.17
Reproducible on current release:
Website problems only:
Additional Information
cc: @bbondy @lukemulks
The text was updated successfully, but these errors were encountered: