-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android 13] Notifications - user manually disable notifications #25042
Comments
Verification PASSED on
|
Example |
Example |
Example |
Example |
Example |
---|---|---|---|---|
Privacy Report Test Cases
- ensured that there's a
Turn on notifications
button under thePrivacy Report
modal if the user disabled OS notifications before enablingPrivacy Report
via onboarding- ensured that tapping on
Turn on notifications
opened theAllow Brave to send you notification
OS modal - ensured that tapping
Allow
enables OS notifications - ensured that
Start browsing to see privacy report
text once the OS notifications have been enabled
- ensured that tapping on
- ensured that the user receives a
You're not receiving Privacy Reports
modal if they've disabled OS notifications butPrivacy Report
has already been enabled - also ensured that the modals only appear once via Enable notifications message on Android 13 should only be shown once #26930 (comment)
Example |
Example |
Example |
Example |
Example |
Example |
---|---|---|---|---|---|
Example video of the feature working --> https://youtube.com/shorts/niVE7t-iVrw
Privacy Report & Reward Test Cases
- ensured that the user receives a
You're not earning Rewards or receiving Privacy Reports
if bothRewards
&Privacy Reports
are enabled but OS notifications have been disabled - also ensured that the modals only appear once via Enable notifications message on Android 13 should only be shown once #26930 (comment)
Example |
Example |
Example |
---|---|---|
Example video of the feature working --> https://youtu.be/OB_fm_Wcfdw
Verification PASSED on Samsung Galaxy Tab S8 Ultra
running Android 13
using the following build(s):
Brave | 1.46.133 Chromium: 108.0.5359.71 (Official Build) (32-bit)
--- | ---
Revision | 1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS | Android 13; Build/TP1A.220624.014
Reward Test Cases
- ensure that the user can opt-in into rewards without any issues if they enabled OS notifications during onboarding
- ensured that the
Allow Brave to send you notification
OS modal appears ifNot now
was selected while onboarding - ensured that the user receives a
Enable notifications from Brave to earn Brave Rewards
if OS notifications have been disabled - ensured that the user receives a
You're not earning Rewards
warning if you've disabled OS notifications but have rewards enabled withSettings
->Brave Rewards
->Show Ads when Brave is not in use
enabled - also ensured that the modals only appear once via Enable notifications message on Android 13 should only be shown once #26930 (comment)
Example video of the feature working --> https://youtu.be/91lEU77PbKQ
Also created #27002 as a follow up.
Example |
Example |
Example |
Example |
Example |
---|---|---|---|---|
Privacy Report Test Cases
- ensured that there's a
Turn on notifications
button under thePrivacy Report
modal if the user disabled OS notifications before enablingPrivacy Report
via onboarding- ensured that tapping on
Turn on notifications
opened theAllow Brave to send you notification
OS modal - ensured that tapping
Allow
enables OS notifications - ensured that
Start browsing to see privacy report
text once the OS notifications have been enabled
- ensured that tapping on
- ensured that the user receives a
You're not receiving Privacy Reports
modal if they've disabled OS notifications butPrivacy Report
has already been enabled - also ensured that the modals only appear once via Enable notifications message on Android 13 should only be shown once #26930 (comment)
Example |
Example |
Example |
Example |
Example |
Example |
---|---|---|---|---|---|
Example video of the feature working --> https://youtube.com/shorts/aGKhwuvN-FM
Privacy Report & Reward Test Cases
- ensured that the user receives a
You're not earning Rewards or receiving Privacy Reports
if bothRewards
&Privacy Reports
are enabled but OS notifications have been disabled - also ensured that the modals only appear once via Enable notifications message on Android 13 should only be shown once #26930 (comment)
Example |
Example |
Example |
---|---|---|
Example video of the feature working --> https://youtube.com/shorts/3ayMzcbh-Ng
Verification PASSED on Samsung Galaxy S10+
running Android 12
using the following build(s):
Brave | 1.46.133 Chromium: 108.0.5359.71 (Official Build) (32-bit)
--- | ---
Revision | 1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS | Android 12; Build/SP1A.210812.016
No OS notification onboarding Test Cases
- ensured that the OS notification onboarding introduced in
Android 13
doesn't appear onAndroid 12
devices - ensured that the OS notifications are enabled by default on
Android 12
Example video of the feature working --> https://youtube.com/shorts/Xq8DRgYp1XU
Reward Test Cases
- ensure that the user can opt-in into rewards without any issues (OS notifications should be enabled by default)
- ensured that the user receives a
Enable notifications from Brave to earn Brave Rewards
if OS notifications have been disabled - ensured that the user receives a
You're not earning Rewards
warning if you've disabled OS notifications but have rewards enabled withSettings
->Brave Rewards
->Show Ads when Brave is not in use
enabled
Example video of the feature working --> https://youtu.be/dCDBY5Vz6_E
Example |
Example |
Example |
---|---|---|
Privacy Report Test Cases
- ensured that there's a
Turn on notifications
button under thePrivacy Report
modal if the user disabled OS notifications before enablingPrivacy Report
via onboarding- ensured that tapping on
Turn on notifications
openedNotifications
underSettings
- ensured that
Start browsing to see privacy report
text once the OS notifications have been enabled
- ensured that tapping on
- ensured that the user receives a
You're not receiving Privacy Reports
modal if they've disabled OS notifications butPrivacy Report
has already been enabled
Example |
Example |
Example |
Example |
Example |
---|---|---|---|---|
Example video of the feature working --> https://youtube.com/shorts/1foDltqouDk
Problem
Android 13 has introduced a notifications permission request modal similar to iOS. Currently this modal appears randomly during the onboarding flow. We are solving for this by triggering a permissions prompt during rewards / privacy report opt-in (further details in #25041). However users will still able to disable notifications manually which would result in:
Solution
We should inform users BEFORE AND AFTER they attempt to disable notifications that this action will impact the private ads and privacy report features.
Requirements
IMPORTANT NOTE: All of the following requirements are conditional to private ads and/or privacy report being ON.
Brave Settings Menu
Android System Settings
Designs
Figma: https://www.figma.com/file/sdVBBufbl2A11hAgPNfyqG/Android-13-Notifications
The text was updated successfully, but these errors were encountered: