-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android 13] Notifications - user manually disable notifications #15407
Conversation
c2d4ec3
to
75a23a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though test plan is empty, preferably add a recording for demo. Before merging, Probably better to get an approval from someone from android rewards team for the flow implementation.
android/java/org/chromium/chrome/browser/notifications/BravePermissionUtils.java
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/notifications/BravePermissionUtils.java
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/notifications/BravePermissionUtils.java
Show resolved
Hide resolved
76ec5f2
to
47dcebc
Compare
e5e69d5
to
1a8e4a3
Compare
f32e042
to
4bfc6a2
Compare
46868ab
to
81b248a
Compare
a579b8f
to
a733e3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
private int mLaunchedFrom; | ||
|
||
public interface DismissListener { | ||
void onDisMiss(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dismiss is a whole word, I wonder why M
capitalized
@@ -159,6 +160,10 @@ public void setNewOnboardingShown(boolean isShown) { | |||
sharedPreferencesEditor.apply(); | |||
} | |||
|
|||
public boolean isBraveRewardsEnabled() { | |||
return mSharedPreferences.getBoolean(BraveRewardsPreferences.PREF_ADS_SWITCH, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be isBraveAdsEnabled as function name ? as we are checking f or ADS_SWITCH pref
update
… clicked notification in brave settings
c365006
to
9f9accf
Compare
Resolves brave/brave-browser#25042
When notification permission is not there and if any of the or both privacy or rewards enabled.
Show a warning dialog to enable notification permission dialog.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
first_time_rewards_use.mp4
Android - 13 Emulator
20221018_160024.mp4