-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android 13 show once notification permission dialog #16079
Android 13 show once notification permission dialog #16079
Conversation
74d386a
to
37454d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to refactor prefs here and update it with SharedPreferenceManager. Can you create an issue for it ?
* Sets the user preference for whether the Notification Permission Enabling dialog is shown. | ||
*/ | ||
public void setNotificationPermissionEnablingDialogShown(boolean isShown) { | ||
SharedPreferences.Editor sharedPreferencesEditor = mSharedPreferences.edit(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should start using SharedPreference Manager for all pref updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We will address refactoring part in upcoming issue.
|
Verification PASSED on
Created brave/brave-browser#27002 after discussing with @deeppandya & @sujitacharya2005. |
Resolves brave/brave-browser#26930
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: