Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install and start button shouldn't be available on brave://ipfs-internals for Android #25103

Closed
stephendonner opened this issue Aug 31, 2022 · 2 comments · Fixed by brave/brave-core#17999

Comments

@stephendonner
Copy link

Description

Install and start button shouldn't be available on brave://ipfs-internals for Android

Steps to Reproduce

  1. install 1.43.86
  2. launch Brave
  3. load brave://ipfs-internals
  4. click on Install and start
  5. wait

Actual result:

Literally nothing happens (confirmed via adb logcat)

initial Installing IPFS...
Screenshot_20220831-083217 Screenshot_20220831-083225

Expected result:

Since IPFS local-node support isn't on Android, we should remove this button.

(And whatever else is only appropriate for public gateway support.)

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.43.86, Chromium 105.0.5195.68 running on Android 9 using a Google Pixel XL

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

cc @spylogsster @cypt4 @srirambv @kjozwiak @Uni-verse

@kjozwiak
Copy link
Member

Moving this into the 1.52.x Nightly which is currently master as it was fixed by brave/brave-core#17999. It wasn't moved automatically due incorrectly formatting being used via brave/brave-core#17999 (comment).

@stephendonner
Copy link
Author

Verified PASSED using

Brave	1.52.87 Chromium: 113.0.5672.77 (Official Build) beta (32-bit)
Revision	c4236862955e005c2187105415ac4a2ecf86dff1-refs/branch-heads/5672_62@{#3}
OS	Android 9; Build/PQ2A.190305.002; 28; REL

running on a Google Pixel XL (arm64), running Android 9.

Confirmed brave://ipfs-internals and/or chrome://ipfs-internals no longer load(s)

example example example
Screenshot_20230505-140220 Screenshot_20230505-140213 Screenshot_20230505-140227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants