Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable ipfs-internals page on Android #29697

Closed
AlexeyBarabash opened this issue Apr 13, 2023 · 1 comment · Fixed by brave/brave-core#17999
Closed

Disable ipfs-internals page on Android #29697

AlexeyBarabash opened this issue Apr 13, 2023 · 1 comment · Fixed by brave/brave-core#17999
Assignees
@AlexeyBarabash
Labels
feature/web3/ipfs OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.52.x - Release

Comments

@AlexeyBarabash
Copy link
Contributor

Since brave://ipfs-internals page is about working with local node, which is not supported on Android - it should be disabled from build to save some space in apk/aab.

Related issues:
#25103
#28060
@AlexeyBarabash AlexeyBarabash added QA/Yes release-notes/exclude feature/web3/ipfs OS/Android Fixes related to Android browser functionality labels Apr 13, 2023
@AlexeyBarabash AlexeyBarabash self-assigned this Apr 13, 2023
@AlexeyBarabash AlexeyBarabash mentioned this issue Apr 13, 2023
Merged
25 tasks
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Apr 20, 2023
@AlexeyBarabash
Disable ipfs-internals webui page on Android
944883e 
Fixes brave/brave-browser#29697.
Fixes brave/brave-browser#25103.

Excluded iOS from enable_ipfs_internals_webui flag (codereview notice)

Assert to ensure ipfs-internals web UI is not built on iOS (codereview notice)

Removed unnecessary #if #endif (codereview notice)
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 20, 2023
@kjozwiak kjozwiak mentioned this issue Apr 20, 2023
Open
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.52.92 x64 beta build

  • Verified steps from brave/brave-core#17999
  • Verified able to load IPFS URI using public gateway settings
  • Verified navigating to brave://ipfs-internals and/or chrome://ipfs-internals doesn't load
  • Verified there is no entry for ipfs-internals page in brave://chrome-pages
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
29697-ARM.mp4
29697-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
feature/web3/ipfs OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.52.x - Release
Development

Successfully merging a pull request may close this issue.

Disable IPFS WebUI on Android brave/brave-core
3 participants
@srirambv @AlexeyBarabash @brave-builds