Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use last opened panel when selecting sidepanel button in toolbar #25229

Closed
rebron opened this issue Sep 6, 2022 · 1 comment · Fixed by brave/brave-core#16822
Closed

Use last opened panel when selecting sidepanel button in toolbar #25229

rebron opened this issue Sep 6, 2022 · 1 comment · Fixed by brave/brave-core#16822
Assignees
Labels
feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 6, 2022

Description

When selecting the side panel button, it will always open the reading list unless the user has removed the reading list from the sidebar, in which case the button will open the bookmarks panel.

Selecting the side panel button should use the last opened panel and toggle the last opened panel on open and close of that button.

Steps to Reproduce

  1. Use 1.44.x and select the side panel button. (notice it opens reading list panel)
  2. Select the bookmarks panel. And close side panel button
  3. Open side panel button and notice it opens reading list panel. Expected to open bookmarks panel again.

Actual and Expected result:

see STR above.

Reproduces how often:

Easily.

Brave version (brave://version info)

1.44.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@stephendonner
Copy link

Verified PASSED using

Brave 1.49.89 Chromium: 110.0.5481.77 (Official Build) beta (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 11.7.3 (Build 20G1116)

Steps:

  1. installed 1.49.89
  2. launched Brave
  3. opened a new-tab page
  4. clicked on the Show Sidebar button
  5. confirmed it opened the Reading List in the left Sidebar panel
  6. selected the Bookmarks icon in the Sidebar panel
  7. clicked to close the Sidebar button
  8. clicked again on the Show Sidebar button

Confirmed it opened with the Bookmarks panel

Step 5 Step 6 Step 7 result
Screen Shot 2023-02-07 at 10 15 51 PM Screen Shot 2023-02-07 at 10 16 11 PM Screen Shot 2023-02-07 at 10 16 26 PM Screen Shot 2023-02-07 at 10 16 34 PM

@rebron rebron changed the title use last opened panel when selecting sidepanel button in toolbar Use last opened panel when selecting sidepanel button in toolbar Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants